From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030314AbXCAVrz (ORCPT ); Thu, 1 Mar 2007 16:47:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030337AbXCAVrz (ORCPT ); Thu, 1 Mar 2007 16:47:55 -0500 Received: from agminet01.oracle.com ([141.146.126.228]:58118 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030314AbXCAVrz (ORCPT ); Thu, 1 Mar 2007 16:47:55 -0500 Message-ID: <45E7493D.2040104@oracle.com> Date: Thu, 01 Mar 2007 13:44:29 -0800 From: Randy Dunlap User-Agent: Thunderbird 1.5.0.5 (X11/20060719) MIME-Version: 1.0 To: Thomas Davies CC: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix warnings that occur on make *docs References: <953c67830703011039x53a28509v3af6dddabffbca9f@mail.gmail.com> <20070301104938.8674ca7b.randy.dunlap@oracle.com> <953c67830703011338n6c9c6b8wafe68b6af6b974b1@mail.gmail.com> In-Reply-To: <953c67830703011338n6c9c6b8wafe68b6af6b974b1@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Whitelist: TRUE X-Whitelist: TRUE X-Brightmail-Tracker: AAAAAQAAAAI= Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Thomas Davies wrote: > On 3/1/07, Randy Dunlap wrote: >> On Thu, 1 Mar 2007 10:39:41 -0800 Thomas Davies wrote: >> >> > From: Thomas Davies >> > >> > Cleaned up comments and whitespace in /drivers/message/fusion/*.c >> and also >> > /lib/bitmap.c to remove make *docs warnings. An attempt by a newbie >> > to contribute >> > in some small way to the codebase. Did I do it right? >> >> Hi, >> >> Your patch looks fine (until I tested it), but I have already >> corrected these warnings. The patches have been in the -mm patchset >> for awhile and Andrew has sent some of it to Linus to be merged. >> Other parts need to go thru other maintainers. > > Thank you for the feedback Randy. Looks like I missed a step in the cycle; > I cloned Linus' tree with git from > git://git.kernel.org/pub/[...]/torvalds/linux-2.6.git, > was this wrong? Is there another tree I should be cloning, or do I > apply the -mm > patch from kernel.org before making this sort of change? (The latter I > suspect.) I don't think that my patches have been merged by Linus yet (sent by Andrew, but there must be some delay there :) . To see if anything has already been patched, it often takes reviewing both Linus's tree and Andrew's -mm patches. Hopefully we don't also need to review all gits of all maintainers, since Andrew tries to merge all of those into the -mm patchset. >> > Signed-off-by: Thomas Davies >> > --- >> > diff -uprN -X linux-2.6/Documentation/dontdiff >> > linux-2.6/drivers/message/fusion/mptbase.c >> > linux-2.6-new/drivers/message/fusion/mptbase.c >> >> Looks like your mail client split these lines (above and below) >> so that 'patch' cannot apply the patch. >> lkml.org shows the same splitting, so I guess it's not my >> mail client on the reading end that is doing this. > > I thought I could get away with using gmail in plain text mode, guess > I'll go back to using mutt. gmail works if you use the SMTP interface to it (or probably with attachments, but they aren't good for reviews/reviewers). Yes, mutt works. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***