From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992724AbXCBXM3 (ORCPT ); Fri, 2 Mar 2007 18:12:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992722AbXCBXM3 (ORCPT ); Fri, 2 Mar 2007 18:12:29 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:54558 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992717AbXCBXM2 (ORCPT ); Fri, 2 Mar 2007 18:12:28 -0500 Message-ID: <45E8AF5A.30902@garzik.org> Date: Fri, 02 Mar 2007 18:12:26 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.9 (X11/20070212) MIME-Version: 1.0 To: Alan CC: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH] pata_legacy: Fix missing methods and add cable types References: <20070301174852.6bd60580@lxorguk.ukuu.org.uk> In-Reply-To: <20070301174852.6bd60580@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Alan wrote: > Several method sets lacked freeze/resume methods. Fix this and while we > are at it force the cable to 40wire > > Signed-off-by: Alan Cox For this, pata_sc1200 and pata_sl82c105: applied the missing-hook portion of the patch, and dropped the ->cable_detect portion pending resend. Please resend the cable_detect patches one this other stuff lands (will push tonight). I would suggest doing two patches: 1) add ->cable_detect hook 2) use ->cable_detect in PATA drivers There is no need to split up the same change across multiple drivers. It is the same logical change, and people doing git-bisect won't be left with a broken configuration, so a single update-drivers patch makes more sense. And, hopefully, is less work for you. Jeff