From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992790AbXCCAOO (ORCPT ); Fri, 2 Mar 2007 19:14:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992789AbXCCAON (ORCPT ); Fri, 2 Mar 2007 19:14:13 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:55038 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992784AbXCCAOM (ORCPT ); Fri, 2 Mar 2007 19:14:12 -0500 Message-ID: <45E8BDD1.5000804@garzik.org> Date: Fri, 02 Mar 2007 19:14:09 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.9 (X11/20070212) MIME-Version: 1.0 To: Alan Cox CC: Robert Hancock , linux-kernel , linux-ide@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2) References: <45DA44B4.6000209@shaw.ca> <45E8B42E.7010900@garzik.org> <20070303005433.714d75ad@lxorguk.ukuu.org.uk> In-Reply-To: <20070303005433.714d75ad@lxorguk.ukuu.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: >> it seems broken to manipulate xfer_mask after returning from the >> driver's ->mode_filter hook. >> >> this patch is more than just a speed-limited warning printk, afaics > > I actually suggested that order because the only way the printk can be > done correctly is for it to be the very last test made. Since the mode > filter is not told what mode will be used but just subtracts modes that > are not allowed this should be safe. OK