From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933666AbXCEVxU (ORCPT ); Mon, 5 Mar 2007 16:53:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933664AbXCEVxT (ORCPT ); Mon, 5 Mar 2007 16:53:19 -0500 Received: from gw1.cosmosbay.com ([86.65.150.130]:47528 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933666AbXCEVxT (ORCPT ); Mon, 5 Mar 2007 16:53:19 -0500 Message-ID: <45EC9129.7050903@cosmosbay.com> Date: Mon, 05 Mar 2007 22:52:41 +0100 From: Eric Dumazet User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Davide Libenzi CC: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton Subject: Re: [patch] epoll use a single inode ... References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (gw1.cosmosbay.com [86.65.150.130]); Mon, 05 Mar 2007 22:52:48 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Davide Libenzi a écrit : > * using the inode number. > */ > error = -ENOMEM; > - sprintf(name, "[%lu]", inode->i_ino); > + sprintf(name, "[%p]", ep); > this.name = name; > this.len = strlen(name); Small remark : you can avoid strlen(), since sprintf gives you the value :) this.len = sprintf(name, "[%p]", ep); Also, your patch description is not complete : you forgot to say that epoll dentries are not anymore hashed into global dcache hashtable :)