public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Publish rcutorture module parameters via sysfs, read-only
@ 2007-03-05 22:01 Josh Triplett
  0 siblings, 0 replies; only message in thread
From: Josh Triplett @ 2007-03-05 22:01 UTC (permalink / raw)
  To: linux-kernel, Paul E. McKenney, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

rcutorture's module parameters currently use permissions of 0, so they don't
show up in /sys/module/rcutorture/parameters.  Change the permissions on all
module parameters to world-readable (0444).

Signed-off-by: Josh Triplett <josh@freedesktop.org>
---
rcutorture does all of its initialization and thread startup when loaded, and
relies on the parameters not changing during execution, so they should not
permit writing.  However, reading seems fine.

 kernel/rcutorture.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
index df49eca..be5114b 100644
--- a/kernel/rcutorture.c
+++ b/kernel/rcutorture.c
@@ -60,19 +60,19 @@ static int test_no_idle_hz;	/* Test RCU's support for tickless idle CPUs. */
 static int shuffle_interval = 5; /* Interval between shuffles (in sec)*/
 static char *torture_type = "rcu"; /* What RCU implementation to torture. */
 
-module_param(nreaders, int, 0);
+module_param(nreaders, int, 0444);
 MODULE_PARM_DESC(nreaders, "Number of RCU reader threads");
-module_param(nfakewriters, int, 0);
+module_param(nfakewriters, int, 0444);
 MODULE_PARM_DESC(nfakewriters, "Number of RCU fake writer threads");
-module_param(stat_interval, int, 0);
+module_param(stat_interval, int, 0444);
 MODULE_PARM_DESC(stat_interval, "Number of seconds between stats printk()s");
-module_param(verbose, bool, 0);
+module_param(verbose, bool, 0444);
 MODULE_PARM_DESC(verbose, "Enable verbose debugging printk()s");
-module_param(test_no_idle_hz, bool, 0);
+module_param(test_no_idle_hz, bool, 0444);
 MODULE_PARM_DESC(test_no_idle_hz, "Test support for tickless idle CPUs");
-module_param(shuffle_interval, int, 0);
+module_param(shuffle_interval, int, 0444);
 MODULE_PARM_DESC(shuffle_interval, "Number of seconds between shuffles");
-module_param(torture_type, charp, 0);
+module_param(torture_type, charp, 0444);
 MODULE_PARM_DESC(torture_type, "Type of RCU to torture (rcu, rcu_bh, srcu)");
 
 #define TORTURE_FLAG "-torture:"
-- 
1.5.0.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-03-05 22:01 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-05 22:01 [PATCH] Publish rcutorture module parameters via sysfs, read-only Josh Triplett

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox