* [PATCH] pata_jmicron: remove spurious #endif
@ 2007-03-03 20:15 Luca Tettamanti
2007-03-05 22:08 ` Kok, Auke
0 siblings, 1 reply; 3+ messages in thread
From: Luca Tettamanti @ 2007-03-03 20:15 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-kernel
Hello,
commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:
CC drivers/ata/pata_jmicron.o
/home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if
make[3]: *** [drivers/ata/pata_jmicron.o] Error 1
Remove a spurious #endif in pata_jmicron driver.
Signed-Off-By: Luca Tettamanti <kronos.it@gmail.com>
---
drivers/ata/pata_jmicron.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/ata/pata_jmicron.c b/drivers/ata/pata_jmicron.c
index 033319e..43763c9 100644
--- a/drivers/ata/pata_jmicron.c
+++ b/drivers/ata/pata_jmicron.c
@@ -244,7 +244,6 @@ static void __exit jmicron_exit(void)
{
pci_unregister_driver(&jmicron_pci_driver);
}
-#endif
module_init(jmicron_init);
module_exit(jmicron_exit);
Luca
--
You and me baby ain't nothin' but mammals
So let's do it like they do on the Discovery Channel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pata_jmicron: remove spurious #endif
2007-03-03 20:15 [PATCH] pata_jmicron: remove spurious #endif Luca Tettamanti
@ 2007-03-05 22:08 ` Kok, Auke
2007-03-05 22:53 ` Luca Tettamanti
0 siblings, 1 reply; 3+ messages in thread
From: Kok, Auke @ 2007-03-05 22:08 UTC (permalink / raw)
To: Luca Tettamanti; +Cc: Tejun Heo, linux-kernel
Luca Tettamanti wrote:
> Hello,
> commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:
>
> CC drivers/ata/pata_jmicron.o
> /home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if
> make[3]: *** [drivers/ata/pata_jmicron.o] Error 1
>
> Remove a spurious #endif in pata_jmicron driver.
I think the problem is that Tejun forgot to *add* a #ifdef CONFIG_PM instead.
Cheers,
Auke
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_jmicron: remove spurious #endif
2007-03-05 22:08 ` Kok, Auke
@ 2007-03-05 22:53 ` Luca Tettamanti
0 siblings, 0 replies; 3+ messages in thread
From: Luca Tettamanti @ 2007-03-05 22:53 UTC (permalink / raw)
To: Kok, Auke; +Cc: Tejun Heo, linux-kernel
On 3/5/07, Kok, Auke <auke-jan.h.kok@intel.com> wrote:
> Luca Tettamanti wrote:
> > Hello,
> > commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:
> >
> > CC drivers/ata/pata_jmicron.o
> > /home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if
> > make[3]: *** [drivers/ata/pata_jmicron.o] Error 1
> >
> > Remove a spurious #endif in pata_jmicron driver.
>
> I think the problem is that Tejun forgot to *add* a #ifdef CONFIG_PM instead.
Nope, that #endif was after the jmicron_exit() function which is
unrelated with CONFIG_PM. I see that Jeff has already commited a
similar patch, mine is no longer needed.
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-05 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-03 20:15 [PATCH] pata_jmicron: remove spurious #endif Luca Tettamanti
2007-03-05 22:08 ` Kok, Auke
2007-03-05 22:53 ` Luca Tettamanti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox