From: Simon Arlott <simon@fire.lp0.eu>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Harald Welte <laforge@gnumonks.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver
Date: Tue, 06 Mar 2007 20:21:09 +0000 [thread overview]
Message-ID: <45EDCD35.80301@simon.arlott.org.uk> (raw)
In-Reply-To: <1173215520.15106.9.camel@aeonflux.holtmann.net>
On 06/03/07 21:12, Marcel Holtmann wrote:
> Hi Linus,
>
> the attached patch fixes a buffer overflow in the Omnikey CardMan 4040
> driver that could lead to a potential arbitrary code execution with
> kernel privileges.
>
> Regards
>
> Marcel
>
- if (count < 5) {
+ if ((count < 5) || (count > READ_WRITE_BUFFER_SIZE)) {
DEBUGP(2, dev, "<- cm4040_write buffersize=%Zd < 5\n", count);
return -EIO;
}
That debug message needs to be changed too since count won't always
be < 5 when it's used.
--
Simon Arlott
prev parent reply other threads:[~2007-03-06 20:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 21:12 [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver Marcel Holtmann
2007-03-06 20:21 ` Simon Arlott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EDCD35.80301@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox