From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932654AbXCGEmd (ORCPT ); Tue, 6 Mar 2007 23:42:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932687AbXCGEmc (ORCPT ); Tue, 6 Mar 2007 23:42:32 -0500 Received: from mail.queued.net ([207.210.101.209]:2242 "EHLO mail.queued.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932654AbXCGEmc (ORCPT ); Tue, 6 Mar 2007 23:42:32 -0500 Message-ID: <45EE42BC.6030209@debian.org> Date: Tue, 06 Mar 2007 23:42:36 -0500 From: Andres Salomon User-Agent: Thunderbird 1.5.0.9 (X11/20070102) MIME-Version: 1.0 To: Dave Jones , Andrew Morton , Andres Salomon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: don't use ZONE_DMA unless CONFIG_ZONE_DMA is set in setup.c References: <45EDFEDB.3000507@debian.org> <20070306175246.b1253ec3.akpm@linux-foundation.org> <20070307040248.GA30278@redhat.com> In-Reply-To: <20070307040248.GA30278@redhat.com> X-Enigmail-Version: 0.94.2.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Dave Jones wrote: > On Tue, Mar 06, 2007 at 05:52:46PM -0800, Andrew Morton wrote: > > On Tue, 06 Mar 2007 18:52:59 -0500 > > Andres Salomon wrote: > > > > > If CONFIG_ZONE_DMA is ever undefined, ZONE_DMA will also not be defined, > > > and setup.c won't compile. This wraps it with an #ifdef. > > > > > > > I guess if anyone tries to disable ZONE_DMA on i386 they'll pretty quickly > > discover that. But I don't think we need to "fix" it yet? Oh, it's certainly not urgent. I sent it simply for correctness reasons. It would've been nice to see the ZONE_DMA removal patches just #define ZONE_DMA regardless, and include less #ifdefs scattered about; but at this point, I'd just as soon prefer to see a proper way to allocate things based on address constraints (as discussed in http://www.gelato.unsw.edu.au/archives/linux-ia64/0609/19036.html). > > CONFIG_ZONE_DMA isn't even optional on i386, so I'm curious how > you could hit this compile failure. > Why, with custom code of course ;)