Re: Radeon xpress 200m and radeonfb kinda work

[johan henriksson <jhn98032@gmail.com>]

Nigel Cunningham wrote:
>  Hi.
>
>  On Tue, 2007-03-06 at 01:16 +0100, Johan Henriksson wrote:
> > Hi!
> >
> > I have gotten the radeon xpress 200m (the version without dedicated
> >  vmem) to work with radeonfb. The attached patch (against
> > linux-2.6.20.1) works for me. Since I don't have any docs for the
> > card I am unsure if the patch is 100% correct. Can someone else
> > with a 200m try it out? (I have tested it by enabling  fbcon and
> > radeonfb in the kernel  and added "video=radeonfb" to lilo. This
> > gave me a nice 1280x800 console :) )
> >
> > /Johan Henriksson
> >
> > Please CC, I'm not on the list.
> >
> > @@ -2329,7 +2332,7 @@ static int __devinit radeonfb_pci_regist /*
> > -2 is special: means  ON on mobility chips and do not * change on
> > others */ -        radeonfb_pm_init(rinfo, rinfo->is_mobility ? 1 : -1,
> > ignore_devlist, force_sleep); +        radeonfb_pm_init(rinfo,
> > -1,ignore_devlist, force_sleep);//rinfo->is_mobility ? 1 : -1);
>
>  That looks like it might break !200M. Maybe something line
>  rinfo->is_mobility && !rinfo->rs480 (with additional modifications to
>  define an rs480, of course) - or a more generic name indicating why
>  the rs480 is different?
>
>  Regards,
>
>  Nigel
>

I know, I am sorry. We could use family as in:
 
rinfo->is_mobility && rinfo->family != CHIP_FAMILY_RS480

Another solution is to add "default_dynclk" to radeonfb_setup
so that everybody with a rs480 can disable it.

I don't have the register specification for the 200m (RS480) so I don't
know why enabling "dynamic clock pm" doesn't work.

/Johan Henriksson