From: "H. Peter Anvin" <hpa@zytor.com>
To: Anton Blanchard <anton@samba.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Roman Zippel <zippel@linux-m68k.org>,
David Brown <dmlb2000@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
gdb@sourceware.org
Subject: Re: PAGE_SIZE Availability Inconsistency
Date: Thu, 08 Mar 2007 10:04:48 -0800 [thread overview]
Message-ID: <45F05040.4090602@zytor.com> (raw)
In-Reply-To: <20070308175729.GA7054@kryten>
Anton Blanchard wrote:
>> By the way, it's a massive snafu that the swap area magic number is
>> dependent on PAGE_SIZE. There is absolutely no good reason for that.
>
> Agreed, its been a big problem booting between 4kB and 64kB kernels on
> ppc64.
The easiest way to fix this would be to always park the swap magic at
the offset of the smallest page size in use, which is 4K. This is
analogous how the offset for the ext2/3 superblock got fixed at 1K --
for 1K blocks, it's the second block, but for larger blocks, it's part
of the first block. If we fix the offset of the swap magic at 4096
minus the offset that's already there, it will always fall in the first
page regardless of page size.
-hpa
next prev parent reply other threads:[~2007-03-08 18:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 23:55 PAGE_SIZE Availability Inconsistency David Brown
2007-03-05 23:59 ` Eric Dumazet
2007-03-06 0:01 ` Randy Dunlap
2007-03-06 0:03 ` David Miller
2007-03-06 0:04 ` David Brown
2007-03-06 0:26 ` David Miller
2007-03-06 2:21 ` H. Peter Anvin
2007-03-08 21:08 ` Avi Kivity
2007-03-08 22:21 ` H. Peter Anvin
2007-03-19 19:39 ` Eric W. Biederman
2007-03-06 9:29 ` Christoph Hellwig
2007-03-08 2:18 ` Roman Zippel
2007-03-08 5:28 ` David Brown
2007-03-08 8:32 ` Christoph Hellwig
2007-03-08 9:00 ` Christoph Hellwig
2007-03-08 15:53 ` Arjan van de Ven
2007-03-08 16:08 ` Christoph Hellwig
2007-03-08 16:21 ` Daniel Jacobowitz
2007-03-08 17:05 ` H. Peter Anvin
2007-03-08 17:12 ` Christoph Hellwig
2007-03-08 17:57 ` Anton Blanchard
2007-03-08 18:04 ` H. Peter Anvin [this message]
2007-03-08 21:42 ` Anton Blanchard
2007-03-08 21:46 ` Anton Blanchard
2007-03-08 21:48 ` David Miller
2007-03-09 2:43 ` Anton Blanchard
2007-03-09 4:18 ` H. Peter Anvin
2007-03-09 4:27 ` David Miller
2007-03-09 4:31 ` H. Peter Anvin
2007-03-09 4:36 ` David Miller
2007-03-21 2:12 ` Anton Blanchard
2007-03-21 2:48 ` H. Peter Anvin
2007-03-08 22:22 ` H. Peter Anvin
2007-03-08 21:03 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F05040.4090602@zytor.com \
--to=hpa@zytor.com \
--cc=anton@samba.org \
--cc=arjan@infradead.org \
--cc=dmlb2000@gmail.com \
--cc=gdb@sourceware.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox