From: Jari Ruusu <jariruusu@users.sourceforge.net>
To: Kandan Venkataraman <kven709@cse.unsw.EDU.AU>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] Loop device - Tracking page writes made to a loop devicethrough mmap
Date: Thu, 08 Mar 2007 21:11:39 +0200 [thread overview]
Message-ID: <45F05FEB.9AED3D31@users.sourceforge.net> (raw)
In-Reply-To: Pine.LNX.4.64.0703081342000.21734@williams.orchestra.cse.unsw.EDU.AU
Kandan Venkataraman wrote:
> All comments have been taken care of.
Your patch still does not do conversions of existing user space visible
'struct loop_info64' which is pretty much cast in stone. Blindly overwriting
larger structure over smaller user space buffer of existing userspace
binaries is the wrong way to do this.
There was a time when folks at least pretended that breaking user space ABI
was not tolerable.
--
Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD
next prev parent reply other threads:[~2007-03-08 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 3:01 [PATCH] Loop device - Tracking page writes made to a loop device through mmap Kandan Venkataraman
2007-03-08 19:11 ` Jari Ruusu [this message]
2007-03-08 20:01 ` [PATCH] Loop device - Tracking page writes made to a loop devicethrough mmap Kandan Venkataraman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F05FEB.9AED3D31@users.sourceforge.net \
--to=jariruusu@users.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=kven709@cse.unsw.EDU.AU \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox