From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933082AbXCHTLs (ORCPT ); Thu, 8 Mar 2007 14:11:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933079AbXCHTLs (ORCPT ); Thu, 8 Mar 2007 14:11:48 -0500 Received: from mail.tnnet.fi ([217.112.240.26]:35642 "EHLO mail.tnnet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933083AbXCHTLr (ORCPT ); Thu, 8 Mar 2007 14:11:47 -0500 Message-ID: <45F05FEB.9AED3D31@users.sourceforge.net> Date: Thu, 08 Mar 2007 21:11:39 +0200 From: Jari Ruusu To: Kandan Venkataraman Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] Loop device - Tracking page writes made to a loop devicethrough mmap References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Kandan Venkataraman wrote: > All comments have been taken care of. Your patch still does not do conversions of existing user space visible 'struct loop_info64' which is pretty much cast in stone. Blindly overwriting larger structure over smaller user space buffer of existing userspace binaries is the wrong way to do this. There was a time when folks at least pretended that breaking user space ABI was not tolerable. -- Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD