Re: [patch] disable NMI watchdog by default

Andi Kleen
2007-03-07T15:30:37Z

On Wednesday 07 March 2007 04:06, Roland Dreier wrote:
> > --- linux.orig/include/asm-x86_64/nmi.h
> > +++ linux/include/asm-x86_64/nmi.h
> > @@ -63,7 +63,7 @@ extern int setup_nmi_watchdog(char *);
> >
> > extern atomic_t nmi_active;
> > extern unsigned int nmi_watchdog;
> > -#define NMI_DEFAULT -1
> > +#define NMI_DEFAULT 0
>
> Maybe I'm missing something obvious, but this patch doesn't seem
> correct to me. The sentiment of disabling the NMI watchdog by default
> is fine, and I agree with it, but I don't think this patch does what
> it says. First of all, I have a system running a kernel with this
> patch applied (v2.6.21-rc2-gc3442e2), and I see NMIs in
> /proc/interrupts and "testing NMI watchdog ... OK." in the log.

Yes the patch looks quite broken.

-Andi