Re: [patch] disable NMI watchdog by default

Linus Torvalds
2007-03-05T20:45:43Z

On Mon, 5 Mar 2007, Ingo Molnar wrote:
>
> Maybe we could take only the 32-bit side of my patch, because that's
> what is most affected by legacies. Although i suspect Windows still
> doesnt inject NMIs in 64-bit mode either, so i dont think there's any
> fundamental difference in terms of breakage in the future, it's just
> that 64-bit systems and 64-bit testing is 1:5 - 1:10 rarer than 32-bit
> testing.

I really don't see the point of having NMI on by default. Debugging that
can cause problems should be disabled. I thought we disabled this a long
time ago - but anyway, now it *really* is (ie I applied your patch).

Anybody who thinks that debugging code is always good is deluded.
Debugging is only good if it has zero downsides and doesn't introduce
problems of its own. And the NMI watchdog clearly isn't in that camp.

If you *actively* debug stuff and/or have actually seen lockups, use the
NMI watchdog. But last I saw, if the machine was running X, the NMI
watchdog wouldn't help *anyway*, so enabling it by default

- has almost zero upsides in the wild _anyway_

- clearly has risks.

so this was a no-brainer. I don't understand why it's even discussed, or
why I hadn't gotten the patch the last time this was discussed.

Linus