* [PATCH] z85230: Fix FIFO handling
@ 2007-03-07 16:37 Alan Cox
2007-03-09 16:51 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Alan Cox @ 2007-03-07 16:37 UTC (permalink / raw)
To: akpm, jgarzik, linux-kernel
We must exit immediately on a FIFO fill not take the end of packet path
otherwise each underrun in PIO transmit mode causes a runt packet and the
data is lost.
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc2-mm2/drivers/net/wan/z85230.c linux-2.6.21-rc2-mm2/drivers/net/wan/z85230.c
--- linux.vanilla-2.6.21-rc2-mm2/drivers/net/wan/z85230.c 2007-03-06 23:06:16.000000000 +0000
+++ linux-2.6.21-rc2-mm2/drivers/net/wan/z85230.c 2007-03-06 16:59:50.000000000 +0000
@@ -407,7 +407,7 @@
while(c->txcount) {
/* FIFO full ? */
if(!(read_zsreg(c, R0)&4))
- break;
+ return;
c->txcount--;
/*
* Shovel out the byte
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-09 16:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-07 16:37 [PATCH] z85230: Fix FIFO handling Alan Cox
2007-03-09 16:51 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox