Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

Alan Cox
2007-03-12T11:07:49Z

> 1. I think these ports should be made dummy instead of returning
> -ENOENT on prereset(). -ENOENT from prereset() was a hack to keep
> ata_piix's behavior unchanged while converting it to new EH. If no
> one objcts, I'll convert similar usages to use dummy ports after new
> init model and drop -ENOENT hack in #upstream.

No objection at all.

> 2. -ENODEV sounds more appropriate. Why have I used -ENOENT. :-)

You didn't - I did. I think -ENOENT is better as we are missing an entire
channel not a device (disk).

>