Re: [PATCH] proc: maps protection

Kees Cook
2007-03-08T21:16:19Z

On Tue, Mar 06, 2007 at 08:22:11PM -0800, Arjan van de Ven wrote:
> > [Adding Cc:lkml]
>
> > How about using a reduced check, as is done for fd and environ? This
> > would allow root-running system monitors to still do their job.
> > Effectively, this changes the test from "is ptracing" to just "can
> > ptrace".
> >
> > If this still isn't considered safe, I'll add the maps_protect file...
>
> btw I consider it an information leak that any user can see which
> files/libraries any other user and root has mmap'd. (and with glibc's
> stdio mmap feature that goes even beyond direct mmap to fopen()'d).
>
> If root or some other user wants to watch
> hillary-vs-obama-in-the-mud.avi, no other user has ANY business even
> seeing that. So at minimum it's a privacy issue showing the filenames...

So, what's the state of this? Is the reduced "allowed to ptrace" check
good enough for inclusion? What is needed for some form of this patch
to be included? I'm happy to try new approaches if I can get some
further input.

Another suggestion was to make this an ELF header toggle, and I'm
generally against that idea. If a toggle is needed, I'd rather it be a
system-wide one.

--
Kees Cook