From: Chuck Ebbert <cebbert@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Theodore Tso <tytso@mit.edu>
Subject: Re: [patch] futex: PI state locking fix
Date: Mon, 12 Mar 2007 10:44:00 -0400 [thread overview]
Message-ID: <45F56730.2050604@redhat.com> (raw)
In-Reply-To: <20070312091342.GA27425@elte.hu>
Ingo Molnar wrote:
> Subject: [patch] futex: PI state locking fix
> From: Ingo Molnar <mingo@elte.hu>
>
> testing of -rt by IBM uncovered a locking bug in wake_futex_pi(): the PI
> state needs to be locked before we access it.
>
> this patch has been tested in -rt. Must-have for v2.6.21.
>
Does that fix this:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=224262
[<c043f3d7>] rt_mutex_next_owner+0x2f/0x40
kernel/rt_mutex_common.c:rt_mutex_top_waiter():74:
BUG_ON(w->lock != lock);
[<c043ecfc>] do_futex+0x94d/0xbe3
inlined: futex_unlock_pi()
inlined: wake_futex_pi()
kernel/futex.c:wake_futex_pi():569:
new_owner = rt_mutex_next_owner(&pi_state->pi_mutex);
[<c043f0af>] sys_futex+0x11d/0x130
[<c040404b>] syscall_call+0x7/0xb
next prev parent reply other threads:[~2007-03-12 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 9:13 [patch] futex: PI state locking fix Ingo Molnar
2007-03-12 9:28 ` Thomas Gleixner
2007-03-12 14:44 ` Chuck Ebbert [this message]
2007-03-12 14:45 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F56730.2050604@redhat.com \
--to=cebbert@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox