From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <ak@suse.de>,
zach@vmware.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix vmi time header bug
Date: Tue, 13 Mar 2007 10:32:23 -0700 [thread overview]
Message-ID: <45F6E027.2060800@goop.org> (raw)
In-Reply-To: <20070313055944.bf89eb9b.akpm@linux-foundation.org>
Andrew Morton wrote:
> Correctly matching the section annotation on declarations and definitions
> is needed by at least ARM. We should ensure that we do this on all future
> patches and we should also apply this patch if only for this reason.
>
> (The ARM thing is a pain, because the compiler cannot check that the
> definition and declaration match. However something like sparse could do
> so).
>
It's also useful documentation. Knowing whether a function is __init is
an important part of its interface.
J
next prev parent reply other threads:[~2007-03-13 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 22:58 [PATCH] Fix vmi time header bug Zachary Amsden
2007-03-13 6:31 ` Andrew Morton
2007-03-13 6:21 ` Zachary Amsden
2007-03-13 6:46 ` Zachary Amsden
2007-03-13 12:45 ` Andi Kleen
2007-03-13 13:59 ` Andrew Morton
2007-03-13 17:32 ` Jeremy Fitzhardinge [this message]
2007-03-13 17:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F6E027.2060800@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox