From: Paulo Marques <pmarques@grupopie.com>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH] Race between cat /proc/kallsyms and rmmod
Date: Wed, 14 Mar 2007 12:55:09 +0000 [thread overview]
Message-ID: <45F7F0AD.9010603@grupopie.com> (raw)
In-Reply-To: <20070314111328.GA6807@localhost.sw.ru>
Alexey Dobriyan wrote:
> Iterating code of /proc/kallsyms calls module_get_kallsym() which grabs
> and drops module_mutex internally and returns "struct module *",
> module is removed, aforementioned "struct module *" is used in non-trivial
> way.
> So, grab module_mutex for entire operation like /proc/modules does.
I would still prefer the other solution to avoid exposing "module_mutex"
outside of module.c like this :(
I'll try to send in a patch today for review.
--
Paulo Marques - www.grupopie.com
"As far as we know, our computer has never had an undetected error."
Weisert
next prev parent reply other threads:[~2007-03-14 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 11:13 [PATCH] Race between cat /proc/kallsyms and rmmod Alexey Dobriyan
2007-03-14 12:11 ` Andi Kleen
2007-03-14 12:55 ` Paulo Marques [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-30 10:23 Weilong Chen
2016-01-30 10:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F7F0AD.9010603@grupopie.com \
--to=pmarques@grupopie.com \
--cc=adobriyan@sw.ru \
--cc=akpm@osdl.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox