From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932805AbXCNTMN (ORCPT ); Wed, 14 Mar 2007 15:12:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932844AbXCNTMN (ORCPT ); Wed, 14 Mar 2007 15:12:13 -0400 Received: from vulpecula.futurs.inria.fr ([195.83.212.5]:36831 "EHLO vulpecula.futurs.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932833AbXCNTMM (ORCPT ); Wed, 14 Mar 2007 15:12:12 -0400 Message-ID: <45F8490A.6000807@tremplin-utc.net> Date: Wed, 14 Mar 2007 20:12:10 +0100 From: =?UTF-8?B?w4lyaWMgUGllbA==?= User-Agent: Thunderbird 2.0b2 (X11/20070307) MIME-Version: 1.0 To: Dmitry Torokhov Cc: Vojtech Pavlik , mitr@volny.cz, otauber@web.de, linux-kernel@vger.kernel.org, linux-input Subject: Re: [PATCH 0/2] wistron_btns: More keymaps References: <45ECA23A.5010503@tremplin-utc.net> <45ED8809.70309@tremplin-utc.net> <45F72D37.6090004@tremplin-utc.net> <20070314182559.GC5264@suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org 03/14/2007 08:02 PM, Dmitry Torokhov wrote/a écrit: > On 3/14/07, Dmitry Torokhov wrote: >> On 3/14/07, Vojtech Pavlik wrote: >> > On Wed, Mar 14, 2007 at 09:54:27AM -0400, Dmitry Torokhov wrote: >> > > Hi Eric, >> > > >> > > 2. I also have a concern about using KEY_SCREEN to signal toggling >> > > display on and off. I am CCing Vojtech - he must know what the >> > > original intent of this key code was. BTW, when user presses >> > > corresponding button - does the display actually goes off? Maybe we >> > > need another switch. >> > >> > Sorry, Dmitry, I probably should have documented it back then, I don't >> > have the slightest idea anymore. >> > >> >> That's what I was afraid of ;) Well, maybe we should just use it to >> indicate display switch and add a comment to that effect to input.h... >> > > Oh, wait, DVB uses this code to request switchin full screen mode, we > better not touch it. > Isn't that what is supposed to do KEY_SWITCHVIDEOMODE? Humm... I've got a feeling that it's not clear where the documentation is or that documentation is missing ;-) IIRC, about a month ago someone already asked for precision on the meaning of some KEY_* . It would probably worth documenting more each key. More specifically, it could be interesting to decide if the keycode has to be associated to the physical symbol displayed on the key or associated to the function that the user (developer) expects when pressing this key. Eric