From: Zachary Amsden <zach@vmware.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, Andi Kleen <ak@muc.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, virtualization@lists.osdl.org,
xen-devel@lists.xensource.com, Chris Wright <chrisw@sous-sol.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@suse.de>
Subject: Re: [patch 28/34] Xen-pv_ops: Xen SMP guest support
Date: Wed, 14 Mar 2007 12:23:43 -0800 [thread overview]
Message-ID: <45F859CF.8040100@vmware.com> (raw)
In-Reply-To: <20070314132820.GL6209@kvack.org>
Benjamin LaHaise wrote:
>
>> +/*
>> + * We aggressively remove defunct pgd from cr3. We execute unmap_vmas()
>> + * *much* faster this way.
>> + */
>>
>
> Are you switching mms in order to avoid all of the overhead associated with
> flushing an active mm during task exit? If so, it makes much more sense to
> do this in the generic helper, as it should be a win on x86 and x86-64
> where switching to init_mm is relatively low cost given the support for
> global pages. I'll run some tests on a couple of systems this evening and
> post the results.
>
I tried this experiment on both x86 and x86-64 and I recall not seeing
any effect. The mmu_gather optimization does most of this already.
Zach
next prev parent reply other threads:[~2007-03-14 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070313233017.933601256@goop.org>
[not found] ` <20070313233034.586018620@goop.org>
2007-03-14 13:28 ` [patch 28/34] Xen-pv_ops: Xen SMP guest support Benjamin LaHaise
2007-03-14 15:05 ` Jeremy Fitzhardinge
2007-03-14 20:23 ` Zachary Amsden [this message]
[not found] ` <20070313233031.149028836@goop.org>
2007-03-16 2:38 ` [patch 10/34] Xen-pv_ops: Simplify smp_call_function*() by using common implementation Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F859CF.8040100@vmware.com \
--to=zach@vmware.com \
--cc=ak@muc.de \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bcrl@kvack.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.osdl.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox