From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Andi Kleen <ak@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jaya Kumar <jayalk@intworks.biz>
Subject: Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups)
Date: Wed, 14 Mar 2007 19:18:16 -0700 [thread overview]
Message-ID: <45F8ACE8.5030704@goop.org> (raw)
In-Reply-To: <200703142342.13639.ak@suse.de>
Andi Kleen wrote:
> On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote:
>
>> The reboot_fixups stuff seems to be a bit of a mess, specifically the
>> header is in linux/ when its a purely i386-specific piece of code. I'm
>> not sure why it has its config option; its only currently needed for
>> "geode-gx1/cs5530a", so perhaps whatever config option controls that
>> hardware should enable this?
>>
>
> Thanks. Looks good.
It looks like a cs5530a is a PATA driver in drivers/ata/pata_cs5530.c.
Seems to me the cleanest fix is to register a reboot notifier in the
driver and have it do the magic rather than have the special
mach_reboot_fixups mechanism at all.
Assuming it needs to be done at all...
Alan? Jaya?
J
next prev parent reply other threads:[~2007-03-15 2:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 22:24 [PATCH] clean up mach_reboot_fixups Jeremy Fitzhardinge
2007-03-14 22:42 ` Andi Kleen
2007-03-15 2:18 ` Jeremy Fitzhardinge [this message]
2007-03-19 14:48 ` Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups) Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F8ACE8.5030704@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jayalk@intworks.biz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox