From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Philip Langdale <philipl@overt.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Carlos Aguiar <carlos.aguiar@indt.org.br>,
juha.yrjola@solidboot.com
Subject: Re: [PATCH] MMC: Fix handling of low-voltage cards
Date: Fri, 16 Mar 2007 09:46:09 +0100 [thread overview]
Message-ID: <45FA5951.2050902@drzeus.cx> (raw)
In-Reply-To: <45F49BE9.6070803@overt.org>
Philip Langdale wrote:
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index c87ce56..74ebd97 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -317,6 +317,24 @@ static u32 mmc_select_voltage(struct mmc
>
The idea with the new structure is to keep a bare minimum of protocol
information in core.c. So stick these tests into mmc.c and sd.c.
> + if (ocr & 0x7F) {
> + printk("%s: card claims to support voltages below "
>
Please include a level with the printk().
> + if (host->mode == MMC_MODE_SD && (ocr & MMC_VDD_165_195)) {
>
Ooops. host->mode should have been removed by now.
Otherwise the patch looks good. Just fix these points and I'll include it.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
prev parent reply other threads:[~2007-03-16 8:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 0:16 [PATCH] MMC: Fix handling of low-voltage cards Philip Langdale
2007-03-16 8:46 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FA5951.2050902@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=carlos.aguiar@indt.org.br \
--cc=juha.yrjola@solidboot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipl@overt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox