From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965680AbXCPRFv (ORCPT ); Fri, 16 Mar 2007 13:05:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965709AbXCPRFv (ORCPT ); Fri, 16 Mar 2007 13:05:51 -0400 Received: from gw.goop.org ([64.81.55.164]:33568 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965680AbXCPRFu (ORCPT ); Fri, 16 Mar 2007 13:05:50 -0400 Message-ID: <45FACE6E.3000901@goop.org> Date: Fri, 16 Mar 2007 10:05:50 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Ingo Molnar CC: Andi Kleen , Andrew Morton , linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Chris Wright , Zachary Amsden , Rusty Russell , Ian Pratt , Christian Limpach , Jan Beulich Subject: Re: [patch 16/26] Xen-paravirt_ops: Allocate and free vmalloc areas References: <20070301232443.195603797@goop.org> <20070301232528.297902504@goop.org> <20070316091648.GI23174@elte.hu> In-Reply-To: <20070316091648.GI23174@elte.hu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: >> +struct vm_struct *alloc_vm_area(unsigned long size) >> > > this should go into mm/vmalloc.c. The trouble is that it calls the arch-dependent vmalloc_sync_all(), which is important for Xen's use of this function. And without that it's just a pointless wrapper around get_vm_area. J