public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: 2.6.21rc suspend to ram regression on Lenovo X60
Date: Fri, 16 Mar 2007 11:37:39 -0700	[thread overview]
Message-ID: <45FAE3F3.1070807@intel.com> (raw)
In-Reply-To: <20070316162117.GA3951@ucw.cz>

Pavel Machek wrote:
> Hi!
> 
>>> Seeing a couple of MSI changes in there, on a hunch I booted latest tree with
>>> pci=nomsi, and it resumed again.
>>>
>>> Any ideas how to further debug this?
>>> I'll try backing out individual changes from that merge tomorrow.
>> Thanks.  
>>
>> Of those msi patches you have identified I don't see anything really
>> obvious.  And you actually marked them as good in your bisect so
>> I don't expect it is core problem.
>>
>> We do have a known e1000 regression, with msi and suspend/resume.

still? I tested this against rc3 and it's mostly just fine. even with msi enabled.

>> So it is possible the nomsi avoided a driver problem.  Especially
>> as we have a number of driver changes on the on Linus's side of
>> that merge.
>>
>> I also know we have some known issues with pci_save_state and
>> pci_restore_state that require them to be paired for correct
>> operation.  For suspend and resume that is not generally a problem.
>>
>> I have fixes for the pci_save_state and pci_restore_state in the -mm
>> and gregkh tree's.  Since they also happen to fix the e1000 driver as
>> a side effect they are worth looking at, at least if you have an
>> e1000.

hey, please include me on those!

>> I don't have a clue which hardware the x60 has so I don't know which
>> drivers it would be using.
> 
> x60 indeed has e1000.

yup.

Auke

  reply	other threads:[~2007-03-16 18:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13  4:08 2.6.21rc suspend to ram regression on Lenovo X60 Dave Jones
2007-03-13  8:11 ` Eric W. Biederman
2007-03-16 16:21   ` Pavel Machek
2007-03-16 18:37     ` Kok, Auke [this message]
2007-03-13  9:22 ` Rafael J. Wysocki
2007-03-13 13:22   ` Dave Jones
2007-03-15 16:11     ` Eric W. Biederman
2007-03-15 17:00       ` Dave Jones
2007-03-15 18:10       ` Dave Jones
2007-03-15 18:24         ` Eric W. Biederman
2007-03-15 19:45         ` Jeremy Fitzhardinge
2007-03-15 20:00           ` Dave Jones
2007-03-13 14:41 ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FAE3F3.1070807@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=davej@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox