From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Tsutomu OWA <tsutomu.owa@toshiba.co.jp>
Cc: mingo@elte.hu, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/6 -rt] powerpc 2.6.20-rt8: add preemption checks for NEED_RESCHED_DELAYED.
Date: Fri, 16 Mar 2007 22:20:27 +0300 [thread overview]
Message-ID: <45FAEDFB.70103@ru.mvista.com> (raw)
In-Reply-To: <yyi7itt25t5.wl@toshiba.co.jp>
Hello.
Tsutomu OWA wrote:
> To add preemption checks for the NEED_RESCHED_DELAYED flag.
> diff -rup linux-rt8/arch/powerpc/kernel/idle.c rt/arch/powerpc/kernel/idle.c
> --- linux-rt8/arch/powerpc/kernel/idle.c 2007-02-20 14:30:38.000000000 +0900
> +++ rt/arch/powerpc/kernel/idle.c 2007-02-20 15:43:04.000000000 +0900
> @@ -56,7 +56,8 @@ void cpu_idle(void)
>
> set_thread_flag(TIF_POLLING_NRFLAG);
> while (1) {
> - while (!need_resched() && !cpu_should_die()) {
> + while (!need_resched() && !need_resched_delayed() &&
> + !cpu_should_die()) {
> ppc64_runlatch_off();
>
> if (ppc_md.power_save) {
Argh, I've missed this one! :-(
But shouldn't we also add !need_resched_delayed() to another place below?
if (ppc_md.power_save) {
[...]
if (!need_resched() && !cpu_should_die())
WBR, Sergei
next prev parent reply other threads:[~2007-03-16 19:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-07 1:34 [patch 0/6 -rt] powerpc 2.6.20-rt8: fix boot/runtime errors/warnings for PowerPC(ppc64) Tsutomu OWA
2007-03-07 1:36 ` [patch 1/6 -rt] powerpc 2.6.20-rt8: add preemption checks for NEED_RESCHED_DELAYED Tsutomu OWA
2007-03-16 19:20 ` Sergei Shtylyov [this message]
2007-03-19 0:00 ` Tsutomu OWA
2007-03-07 1:37 ` [patch 2/6 -rt] powerpc 2.6.20-rt8: to convert spinlocks to raw ones Tsutomu OWA
2007-03-07 14:38 ` Sergei Shtylyov
2007-03-07 14:43 ` Benjamin Herrenschmidt
2007-03-07 14:54 ` Sergei Shtylyov
2007-03-07 16:49 ` Paul Mackerras
2007-03-07 17:30 ` Sergei Shtylyov
2007-03-07 19:21 ` Paul Mackerras
2007-03-07 21:21 ` Sergei Shtylyov
2007-03-07 21:30 ` Paul Mackerras
2007-03-08 0:43 ` Bill Huey
2007-03-08 3:26 ` Paul Mackerras
2007-03-08 4:00 ` Bill Huey
2007-03-07 1:39 ` [patch 3/6 -rt] powerpc 2.6.20-rt8: fix a runtime warning for smp_processor_id() Tsutomu OWA
2007-03-07 1:42 ` [RFC] [patch 4/6 -rt] powerpc 2.6.20-rt8: fix a runtime warnings for xmon Tsutomu OWA
2007-03-07 9:16 ` Ingo Molnar
2007-03-07 10:10 ` Benjamin Herrenschmidt
2007-03-07 10:54 ` Tsutomu OWA
2007-03-07 11:06 ` Arnd Bergmann
2007-03-07 1:45 ` [RFC] [patch 5/6] powerpc 2.6.20-rt8: fix a boot error for handle_percpu_irq Tsutomu OWA
2007-03-07 21:29 ` Sergei Shtylyov
2007-03-07 1:47 ` [patch 6/6 -rt] powerpc 2.6.20-rt8: fix boot/runtime errors/warnings Tsutomu OWA
2007-03-07 9:13 ` [patch 0/6 -rt] powerpc 2.6.20-rt8: fix boot/runtime errors/warnings for PowerPC(ppc64) Ingo Molnar
2007-03-07 14:26 ` Sergei Shtylyov
2007-03-08 2:28 ` Tsutomu OWA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FAEDFB.70103@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=tsutomu.owa@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox