From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966006AbXCQAnW (ORCPT ); Fri, 16 Mar 2007 20:43:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966010AbXCQAnW (ORCPT ); Fri, 16 Mar 2007 20:43:22 -0400 Received: from gw.goop.org ([64.81.55.164]:35968 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966006AbXCQAnV (ORCPT ); Fri, 16 Mar 2007 20:43:21 -0400 Message-ID: <45FB39A4.5020706@goop.org> Date: Fri, 16 Mar 2007 17:43:16 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Andrew Morton CC: Dan Hecht , Zachary Amsden , Virtualization Mailing List , Linux Kernel Mailing List , john stultz Subject: Re: [PATCH/RFC] replace get_scheduled_cycles with sched_clock paravirt_op References: <45F847E2.7040102@goop.org> <20070316163026.7a474142.akpm@linux-foundation.org> In-Reply-To: <20070316163026.7a474142.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Wed, 14 Mar 2007 12:07:14 -0700 Jeremy Fitzhardinge wrote: > > >> Subject: Add a sched_clock paravirt_op >> >> The tsc-based get_scheduled_cycles interface is not a good match for >> Xen's runstate accounting, which reports everything in nanoseconds. >> >> This patch replaces this interface with a sched_clock interface, which >> matches both Xen and VMI's requirements. >> >> In order to do this, we: >> 1. replace get_scheduled_cycles with sched_clock >> 2. hoist cycles_2_ns into a common header >> 3. update vmi accordingly >> >> One thing to note: because sched_clock is implemented as a weak function in >> kernel/sched.c, we must define a real function in order to override this weak >> binding. This means the usual paravirt_ops technique of using an inline >> function won't work in this case. >> > > include/asm/paravirt.h: In function 'paravirt_sched_clock': > include/asm/paravirt.h:281: warning: implicit declaration of function 'PVOP_CALL0' > include/asm/paravirt.h:281: error: expected expression before 'unsigned' > Sorry, I didn't intend for it to be picked up; it depends on stuff earlier in the patch series. I just wanted to check with the VMI folks that it works for them in principle. J