public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Meyer <thomas@m3y3r.de>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug in pci_restore_msi_state
Date: Sat, 17 Mar 2007 19:31:44 +0100	[thread overview]
Message-ID: <45FC3410.4060907@m3y3r.de> (raw)
In-Reply-To: <84144f020703170618x73808b4fmf5b420f4c2e02818@mail.gmail.com>

Pekka Enberg schrieb:
> On 3/17/07, Thomas Meyer <thomas@m3y3r.de> wrote:
>> Hello everybody.
>>
>> I get this bug after suspending to disk twice:
>>
>> http://m3y3r.de/bilder/Bug-pci_restore_msi_state.png
>>
>> This happens with current git head
>> cd05a1f818073a623455a58e756c5b419fc98db9.
>
> If you know a kernel that works, please consider doing git bisect:
>
> http://www.kernel.org/pub/software/scm/git/docs/howto/isolate-bugs-with-bisect.txt
>
>
I don't think so, because suspend to disk began to work again with the
latest commit.

But it seems to have to do with dev->msi_enabled, that is enabled, but
the msi_attrib for this device is empty (pos is zero) in the function
__pci_restore_msi_state. irq=19 and msi_attrib=0 before the bug happens
(trying to accessing msi_attrib.pos).
But 19 is not an msi interrupt, isn't it?

           CPU0       CPU1
  0:     168998          0   IO-APIC-edge      timer
  9:       9056          0   IO-APIC-fasteoi   acpi
 16:         43          0   IO-APIC-fasteoi   uhci_hcd:usb5
 17:       8278      19996   IO-APIC-fasteoi   wifi0
 18:      11388          0   IO-APIC-fasteoi   libata, uhci_hcd:usb4
 19:          3          0   IO-APIC-fasteoi   uhci_hcd:usb3, ohci1394
 20:     115285          0   IO-APIC-fasteoi   ehci_hcd:usb1, uhci_hcd:usb2
 21:        225          0   IO-APIC-fasteoi   HDA Intel
218:      14365          0   PCI-MSI-edge      libata
219:          1          0   PCI-MSI-edge      eth0
NMI:          0          0
LOC:      49119      88723
ERR:          0
MIS:          0

Shouldn't  the flag msi_enabled be set to zero in function
msi_remove_pci_irq_vectors?



  reply	other threads:[~2007-03-17 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-17 12:42 Bug in pci_restore_msi_state Thomas Meyer
2007-03-17 13:18 ` Pekka Enberg
2007-03-17 18:31   ` Thomas Meyer [this message]
2007-03-20 21:07   ` Thomas Meyer
2007-03-18 17:53 ` Thomas Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FC3410.4060907@m3y3r.de \
    --to=thomas@m3y3r.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox