Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

YOSHIFUJI Hideaki / 吉藤英明
2007-01-09T01:24:08Z

In article <20070104122330.GA2233@craigdell.detnet.com> (at Thu, 4 Jan 2007 14:23:30 +0200), Craig Schlenter <craig@codefountain.com> says:

> On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote:
> > Hi,
> >
> > I made a patch below.
> > With this patch, the ftp-transfer-stop problem does not happen.
> > Therefore, I think this is not a problem of vsftpd.
> >
> > Mr.YOSHIFUJI san, why did you set TCPOLEN_TSTAMP_ALIGNED
> > to iov_len?
> >
> >
> >
> > --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.000000000 +0900
> > +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c 2007-01-03 15:30:44.000000000 +0900
> > @@ -648,7 +648,7 @@ static void tcp_v4_send_ack(struct tcp_t
> > TCPOLEN_TIMESTAMP);
> > rep.opt[1] = htonl(tcp_time_stamp);
> > rep.opt[2] = htonl(ts);
> > - arg.iov[0].iov_len = TCPOLEN_TSTAMP_ALIGNED;
> > + arg.iov[0].iov_len = sizeof(rep);
>
> Perhaps this was supposed to be
> arg.iov[0].iov_len += TCPOLEN_TSTAMP_ALIGNED;
>
> That's what the ipv6 stuff does in places.

Good catch! I agree.
Craig, please provide a patch for us, please.

Thank you again.

--yoshfuji