From: Bill Davidsen <davidsen@tmr.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>,
linux-kernel@vger.kernel.org, yumiko.sugita.yf@hitachi.com,
masami.hiramatsu.pt@hitachi.com, hidehiro.kawai.ez@hitachi.com,
yuji.kakutani.uw@hitachi.com, soshima@redhat.com,
haoki@redhat.com, kamezawa.hiroyu@jp.fujitsu.com,
nikita@clusterfs.com, leroy.vanlogchem@wldelft.nl
Subject: Re: [PATCH 0/3] VM throttling: avoid blocking occasional writers
Date: Sun, 18 Mar 2007 09:59:39 -0500 [thread overview]
Message-ID: <45FD53DB.5000207@tmr.com> (raw)
In-Reply-To: <20070315110745.af867b10.akpm@linux-foundation.org>
Andrew Morton wrote:
>> On Wed, 14 Mar 2007 21:42:46 +0900 Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:
>>
>> ...
>>
>>
>> -Solution:
>>
>> I consider that all of the dirty pages for the disk have been written
>> back and that the disk is clean if a process cannot write 'write_chunk'
>> pages in balance_dirty_pages().
>>
>> To avoid using up the free memory with dirty pages by passing blocking,
>> this patchset adds a new threshold named vm.dirty_limit_ratio to sysctl.
>>
>> It modifies balance_dirty_pages() not to block when the amount of
>> Dirty+Writeback is less than vm.dirty_limit_ratio percent of the memory.
>> In the other cases, writers are throttled as current Linux does.
>>
>>
>> In this patchset, vm.dirty_limit_ratio, instead of vm.dirty_ratio, is
>> used as the clamping level of Dirty+Writeback. And, vm.dirty_ratio is
>> used as the level at which a writers will itself start writeback of the
>> dirty pages.
>
> Might be a reasonable solution - let's see what Peter comes up with too.
>
> Comments on the patch:
>
> - Please don't VM_DIRTY_LIMIT_RATIO: just use CTL_UNNUMBERED and leave
> sysctl.h alone.
>
> - The 40% default is already too high. Let's set this new upper limit to
> 40% and decrease he non-blocking ratio.
>
> - Please update the procfs documentation in ./Docmentation/
>
> - I wonder if dirty_limit_ratio is the best name we could choose.
> vm_dirty_blocking_ratio, perhaps? Dunno.
>
I don't like it, but I dislike it less than "dirty_limit_ratio" I guess.
It would probably break things to change it now, including my
sysctl.conf on a number of systems :-(
--
Bill Davidsen <davidsen@tmr.com>
"We have more to fear from the bungling of the incompetent than from
the machinations of the wicked." - from Slashdot
next prev parent reply other threads:[~2007-03-18 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 12:42 [PATCH 0/3] VM throttling: avoid blocking occasional writers Tomoki Sekiyama
2007-03-14 13:18 ` Peter Zijlstra
2007-03-15 19:07 ` Andrew Morton
2007-03-18 14:59 ` Bill Davidsen [this message]
2007-03-22 5:49 ` Tomoki Sekiyama
2007-03-22 11:41 ` Bill Davidsen
2007-03-26 10:27 ` Tomoki Sekiyama
2007-03-26 17:11 ` Bill Davidsen
2007-04-03 10:42 ` Tomoki Sekiyama
2007-04-03 10:46 ` [PATCH 1/2] VM throttling: Start writeback at dirty_writeback_start_ratio Tomoki Sekiyama
2007-04-06 0:31 ` Andrew Morton
2007-04-10 3:04 ` Tomoki Sekiyama
2007-04-10 3:46 ` Andrew Morton
2007-04-03 10:47 ` [PATCH 2/2] VM throttling: Add vm.dirty_start_writeback_ratio to sysctl Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FD53DB.5000207@tmr.com \
--to=davidsen@tmr.com \
--cc=akpm@linux-foundation.org \
--cc=haoki@redhat.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=leroy.vanlogchem@wldelft.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=nikita@clusterfs.com \
--cc=soshima@redhat.com \
--cc=tomoki.sekiyama.qu@hitachi.com \
--cc=yuji.kakutani.uw@hitachi.com \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox