Re: [patch 03/26] Xen-paravirt_ops: use paravirt_nop to consistently mark no-op operations

Ingo Molnar
2007-03-16T09:44:54Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Add a _paravirt_nop function for use as a stub for no-op operations,
> and paravirt_nop #defined void * version to make using it easier
> (since all its uses are as a void *).
>
> This is useful to allow the patcher to automatically identify noop
> operations so it can simply nop out the callsite.

Acked-by: Ingo Molnar <mingo@elte.hu>

> +void _paravirt_nop(void);
> +#define paravirt_nop ((void *)_paravirt_nop)

but only as a cleanup of the current open-coded (void *) casts. My
problem with this is that it loses the types. Not that there is much to
check for, but still, this adds some assumptions about how function
calls look like.

Ingo