Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

Ingo Molnar
2007-03-16T09:34:39Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> This patch introduces paravirt_ops hooks to control how the kernel's
> initial pagetable is set up.

looks good. Some minor nits:

> + /* Make sure kernel address space is empty so that a pagetable
> + will be allocated for it. */

comment style.

> + /* Enable PSE if available */
> + if (cpu_has_pse) {
> + set_in_cr4(X86_CR4_PSE);
> + }

unnecessary braces.

Ingo