Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

Michal Piotrowski
2007-03-19T18:04:15Z

Michal Piotrowski napisał(a):
> On 19/03/07, Michal Piotrowski <michal.k.k.piotrowski@gmail.com> wrote:
>> On 19/03/07, Pekka J Enberg <penberg@cs.helsinki.fi> wrote:
>> > On Mon, 19 Mar 2007, Michal Piotrowski wrote:
>> > > Yes, revoke-special-mmap-handling.patch is bad.
>> >
>> > Aah, the VM_REVOKED flag stomps on VM_CAN_INVALIDATE in -mm. Changing
>> > VM_REVOKED to 0x10000000 should fix it.
>
> Unfortunately it doesn't. 0x10000000 is used by VM_CAN_NONLINEAR.
> 0x20000000 should be a better value.

Here is a tested patch.

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)

Signed-off-by: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>
Signed-off-by: Pekka J Enberg <penberg@cs.helsinki.fi>

--- linux-work1-clean/include/linux/mm.h 2007-03-19 18:52:28.000000000 +0100
+++ linux-work1/include/linux/mm.h 2007-03-19 18:23:04.000000000 +0100
@@ -173,7 +173,6 @@ extern int do_mprotect(unsigned long sta
#define VM_MAPPED_COPY 0x01000000 /* T if mapped copy of data (nommu mmap) */
#define VM_INSERTPAGE 0x02000000 /* The vma has had "vm_insert_page()" done on it */
#define VM_ALWAYSDUMP 0x04000000 /* Always include in core dumps */
-#define VM_REVOKED 0x08000000 /* Mapping has been revoked */

#define VM_CAN_INVALIDATE 0x08000000 /* The mapping may be invalidated,
* eg. truncate or invalidate_inode_*.
@@ -181,6 +180,7 @@ extern int do_mprotect(unsigned long sta
* return with the page locked.
*/
#define VM_CAN_NONLINEAR 0x10000000 /* Has ->fault & does nonlinear pages */
+#define VM_REVOKED 0x20000000 /* Mapping has been revoked */

#ifndef VM_STACK_DEFAULT_FLAGS /* arch can override this */
#define VM_STACK_DEFAULT_FLAGS VM_DATA_DEFAULT_FLAGS