Re: [RFC][PATCH -mm take3 1/6][resend] marking __init

Matt Mackall
2007-03-20T15:49:11Z

On Tue, Mar 20, 2007 at 09:24:18PM +0900, Keiichi KII wrote:
> From: Keiichi KII <k-keiichi@bx.jp.nec.com>
>
> This patch contains the following cleanups.
> - add __init for initialization functions(option_setup() and
> init_netconsole()).
>
> Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
> Signed-off-by: Takayoshi Kochi <t-kochi@bq.jp.nec.com>
> ---
> Index: linux-mm/drivers/net/netconsole.c
> ===================================================================
> --- linux-mm.orig/drivers/net/netconsole.c
> +++ linux-mm/drivers/net/netconsole.c
> @@ -91,7 +91,7 @@ static struct console netconsole = {
> .write = write_msg
> };
>
> -static int option_setup(char *opt)
> +static int __init option_setup(char *opt)
> {
> configured = !netpoll_parse_options(&np, opt);
> return 1;
> @@ -99,7 +99,7 @@ static int option_setup(char *opt)
>
> __setup("netconsole=", option_setup);
>
> -static int init_netconsole(void)
> +static int __init init_netconsole(void)
> {
> int err;

This is fine.

Acked-by: Matt Mackall <mpm@selenic.com>

--
Mathematics is the supreme nostalgia of our time.