From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB9B2459FD for ; Wed, 24 Dec 2025 02:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766542336; cv=none; b=httIWuRGx2UMEkD6dG/N62HEF3JWJQwY77oyxz2otC7qHCMdAqO04MU81h9hj2OpBYMjnVVYF83HSRYuBVdESKQOWiPhnpAyCIa147nSgYcCYsRWkoHx+pPAZqvTu/3y/MgHx7H2lI+y51M4VnDXr/24kbHAmzgLiJbD5wuge1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766542336; c=relaxed/simple; bh=37z/owpX5jfxrYEHklbiOeTahWQfH6uG0Auq7XulCIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kabmQgcD0TrPWUPDU60qkf0JGoRJy77Tq2sBgi+Y8OcoNakponMIWn+pIaD4myz3vVZk2E6pxKOsDFcHApcAbtEeUVTe4jWITnv+hE/1nQ1ma3RuPKRQibwj6SGip/quZA7kmNPXnD8fptkcze0+YQ3Akqx7JAs0OQgOg4Qjb2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gf1h1UMB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KCLerXio; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gf1h1UMB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KCLerXio" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNFr8wV4134161 for ; Wed, 24 Dec 2025 02:12:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 35S/WHqipbDYewb3d4hGu+2ig6o+3xLs6XWJlU23x8Y=; b=gf1h1UMBXUVCcEaW arSRd5gfyjau6zyWQcWi5uC0Zmng2GGjvp227BDdv3vdyeLv+jvsG4ElYFRkSBcY 05bDJ9G8XdQOyoqhYvtJbJlu/0S7jLCAwToGDFdMNOBMm+8SMV114OFCyJQr88py Miz1FqxV+4OZxdO8DmEwDqedrWuoI/tn6vuUyOU7yfT25nbd5S1kBM139IHL1Rmn jHVKkZ4YuCO9wN/TinO139Fw6Oratz0WM4sp4FYsIpLTPRYFOHZN+aBotK1xx3XM q5MgkZgGcdzh42CIA6hcKtb1WJq/tiIZ+GyfPzQVjOshkTuMkVu/vu+7joCWkvzN Yzu97g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7x46sjpu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 02:12:13 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed74ab4172so130581221cf.1 for ; Tue, 23 Dec 2025 18:12:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766542333; x=1767147133; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=35S/WHqipbDYewb3d4hGu+2ig6o+3xLs6XWJlU23x8Y=; b=KCLerXioRgeWRJjiJ3PQfJA3boEzMIABxPIhBRNHfBX8SlSnKp/owxFfe457EnIi1S x8y8p70G/xsE5LaXSh37HsKfMwz92/oZ8L9xjBper1s3gFS2+nTTUDckcBOcYLysNGf2 vtnia4k7YrmsOMISSC3+FCSRsJiRSK1LGpMmwmbTkJX3YPW+10m20BL2o2sDz8bOY5B5 uFYZtXj8mGBZ0Jx9l/7QZPbcpNpIISz6UmdFiJMHrl5sLya4qmil3lzl29z21lXAikAC +p1XVi/kbTAFLnKxKCi58ApBWydkXM1T/QBls2vcrl3SGVgzVdv/UzcxbToo5GZ7ucbn sMqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766542333; x=1767147133; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=35S/WHqipbDYewb3d4hGu+2ig6o+3xLs6XWJlU23x8Y=; b=hUiXEVOfkxjLRpX6M/JhTeKx5r0NCFKmiqjL6IrVyLf9ksdg48iYRznen5tDW8iKTM l0yQgRTmoFfvgYRe31yrmsL2G5iRXjE2EJJ4wxDHjq77X96bKjT8FyOz1Vm3YCbkpf2t AgsDgpjNymerhyBCwJKe+XNjWcdQZK9yMqN5VKcbcbeQQSmhNRXmd0O0Hf86umnsHrnK BTGQjvsGNPz5ulNdurHahSDyX2rSSoqT4uQpYWq0J3QMg3wAhmQi4X+1Y0THEd0QykUc cCsXK/ODVPTgXJ4PWl+8mKaWJpEwJR6LYKxTZu6py6+Tjb07VE1khaujyhE9emr8u+kY RpKw== X-Forwarded-Encrypted: i=1; AJvYcCUTgmatmmUS9J0FYpA/RTWdsHQPUIY0KW2jtBr292MSI/uouA931e0OfFxQgO1d951dShU8aRj/jT1pm0g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6GT029zZkfZXblusOWU3NFGxVdk7p3ShXCs950y7LI1nd+3vF oBLr63uMq66YyQ14iUktKECAFAlIdghRXOWcViXDdUQXo0cyJvFsz/6NTUwTPZS55yWZbVnLIqr ZbisOXwoqIS7r+B7OiHW0pjJaIG2Xbz0imHdEIM+cshbxI4ELL9g8vZWmtEuM5mNUKJg= X-Gm-Gg: AY/fxX41EsuyjXuZm6pkYdsyK/+6iun5gSRB3Mon5IPkYj5ZFtkTQFJ2oYDSywMe/81 kEcvQMjXw+siI5VmD4qKAwfE3Y0Um7wVKKBsSex6/QSqtZu8Xa+FtOJTEqe/FfQIXtB4Tnjn7Lv +aP4DUyRBd7mrG7U9tMjyPTJpOSQmZIrqMF39re6S0tGUSnpd1AszFof77iiX0TBDpIcU03JO/0 mbgUbjInzmuuTRtKG7cPmSb1bBFRaN5ZARTovLSZw4v5FSyZynlE38XaaKHxhw5QuhqcLixQxTI zi2shMbm8VivIiDZ3eAEbo77oJYvmCB6bgAIby6F9SissMfwv42Z4cI4CbsGl2BVLUXcTBHiJhs w5c/qXb+80yhKTWb5iz8KrkT/i/KXuIiEH5TxdfaoOmK1axZp/sDwnGYagYjpG4qdj/Jz05Bp3g == X-Received: by 2002:a05:622a:1e96:b0:4ee:1dd0:5a51 with SMTP id d75a77b69052e-4f4abcf632fmr212572741cf.2.1766542332870; Tue, 23 Dec 2025 18:12:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXXNTnPitVDMJVOsCBUeJpenK/gHnhoi7SLokwYZjACPve2gmLZdKA88zpHtCRpH41wfINfg== X-Received: by 2002:a05:622a:1e96:b0:4ee:1dd0:5a51 with SMTP id d75a77b69052e-4f4abcf632fmr212572531cf.2.1766542332317; Tue, 23 Dec 2025 18:12:12 -0800 (PST) Received: from [10.111.161.169] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88d997aeef5sm121407036d6.27.2025.12.23.18.12.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Dec 2025 18:12:11 -0800 (PST) Message-ID: <45aa9656-dbbd-4c1e-89c4-a24ea5996ff1@oss.qualcomm.com> Date: Wed, 24 Dec 2025 10:12:04 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: qcom: talos-evk-camera: Add DT overlay To: Vladimir Zapolskiy , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org References: <20251222-sm6150_evk-v1-0-4d260a31c00d@oss.qualcomm.com> <20251222-sm6150_evk-v1-3-4d260a31c00d@oss.qualcomm.com> <703a502c-883d-434a-8bcf-f785080f5102@oss.qualcomm.com> <091b863b-fa0a-4d3c-8461-60cdc4970992@linaro.org> Content-Language: en-US From: Wenmeng Liu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: pMlcavCxlionmqCXzYMdTYgw5NMg7s7E X-Proofpoint-GUID: pMlcavCxlionmqCXzYMdTYgw5NMg7s7E X-Authority-Analysis: v=2.4 cv=aOf9aL9m c=1 sm=1 tr=0 ts=694b4bfd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=3HrGEc0Bd40ySK1zDqwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDAxNSBTYWx0ZWRfX0yLxV7+p4tcR UeA+37wyct45HLNTkX5UegvNHrUv6nO2QNiVF5Q9MBpwYtj4JiTZLe03UOCUjP/WBvQQMvHXEaR W7EwzkZbhPd49MmFyJZiIjg7A28qt2OpDHPFBEllhWCfAe7rwxORGJuq2fAf+36N53Qp3GOh9lr QO6OT+2ONKisBEVefGV4FH49Z+YJ67/+isjRysJG+lhg+0g2Bd1y/tP41nHjQ/xdRgVJnlIYpzU 3WX7evQj397r78y3F93HoIB3oazLUNQDoYPVEd62vDVGmxUOKL4TX0q200/oC2oBcnUGe4C2wXb VI8tjiQlisCFeEQdDRHwhZIaKElcbgRpxkXxgKTIUaSMtryJIoUWGHAWxtA3Bcm9iIG4TpvVfBI 2v3+NBAYBGuMPblxWZ4+naz93vi0If28uJqZJWjQ1WWfEcDo8BArE/N+dko3P0MtP20JXZgXBrK xGyc6zNusIExEGwdBaQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-23_05,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240015 On 12/24/2025 12:36 AM, Vladimir Zapolskiy wrote: > On 12/23/25 04:16, Wenmeng Liu wrote: >> >> >> On 12/22/2025 11:45 PM, Vladimir Zapolskiy wrote: >>> On 12/22/25 13:41, Wenmeng Liu wrote: >>>> >>>> >>>> On 12/22/2025 7:19 PM, Vladimir Zapolskiy wrote: >>>>> On 12/22/25 10:44, Wenmeng Liu wrote: >>>>>> Enable IMX577 via CCI on Taloss EVK Core Kit. >>>>>> >>>>>> The Talos EVK board does not include a camera sensor >>>>>> by default, this overlay reflects the possibility of >>>>>> attaching an optional camera sensor. >>>>>> For this reason, the camera sensor configuration is >>>>>> placed in talos-evk-camera.dtso, rather than >>>>>> modifying the base talos-evk.dts. >>>>>> >>>>>> Signed-off-by: Wenmeng Liu >>>>>> --- >>>>>>     arch/arm64/boot/dts/qcom/Makefile              |  2 + >>>>>>     arch/arm64/boot/dts/qcom/talos-evk-camera.dtso | 64 ++++++++++ >>>>>> ++++++ >>>>>> ++++++++++ >>>>>>     arch/arm64/boot/dts/qcom/talos.dtsi            | 21 +++++++++ >>>>> >>>>> Please split QCS615 MCLK definitions change into a separate commit. >>>> ACK.> >>>>>>     3 files changed, 87 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/ >>>>>> qcom/Makefile >>>>>> index >>>>>> 60121f133078b2754f98e6f45a3db4031b478cc8..b1d85b1f4a94714f2a5c976d162482d70ae920f2 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/Makefile >>>>>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>>>>> @@ -325,7 +325,9 @@ dtb-$(CONFIG_ARCH_QCOM)    += sm8650-qrd.dtb >>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += sm8750-mtp.dtb >>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += sm8750-qrd.dtb >>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += talos-evk.dtb >>>>>> +talos-evk-camera-dtbs        := talos-evk.dtb talos-evk-camera.dtbo >>>>>>     talos-evk-lvds-auo,g133han01-dtbs    := talos-evk.dtb talos-evk- >>>>>> lvds-auo,g133han01.dtbo >>>>>> +dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-camera.dtb >>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += talos-evk-lvds-auo,g133han01.dtb >>>>>>     x1e001de-devkit-el2-dtbs    := x1e001de-devkit.dtb x1-el2.dtbo >>>>>>     dtb-$(CONFIG_ARCH_QCOM)    += x1e001de-devkit.dtb x1e001de- >>>>>> devkit- >>>>>> el2.dtb >>>>>> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso b/arch/ >>>>>> arm64/boot/dts/qcom/talos-evk-camera.dtso >>>>>> new file mode 100644 >>>>>> index >>>>>> 0000000000000000000000000000000000000000..ae1a02295b4dc48212aad40980a329ff458fe69a >>>>>> --- /dev/null >>>>>> +++ b/arch/arm64/boot/dts/qcom/talos-evk-camera.dtso >>>>>> @@ -0,0 +1,64 @@ >>>>>> +// SPDX-License-Identifier: BSD-3-Clause >>>>>> +/* >>>>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its >>>>>> subsidiaries. >>>>> >>>>> Please add a missing year of the change. >>>> Now our requirement is a yearless copyright.> >>> >>> Ack. It's a lawyers' domain anyway. >>> >>>>>> + */ >>>>>> + >>>>>> +/dts-v1/; >>>>>> +/plugin/; >>>>>> + >>>>>> +#include >>>>>> +#include >>>>>> + >>>>>> +&camss { >>>>>> +    vdd-csiphy-1p2-supply = <&vreg_l11a>; >>>>>> +    vdd-csiphy-1p8-supply = <&vreg_l12a>; >>>>>> + >>>>>> +    status = "okay"; >>>>>> + >>>>>> +    ports { >>>>>> +        #address-cells = <1>; >>>>>> +        #size-cells = <0>; >>>>>> + >>>>>> +        port@1 { >>>>>> +            reg = <1>; >>>>>> + >>>>>> +            csiphy1_ep: endpoint { >>>>>> +                clock-lanes = <7>; >>>>> >>>>> Please remove 'clock-lanes' property. >>>> ACK.> >>>>>> +                data-lanes = <0 1 2 3>; >>>>>> +                remote-endpoint = <&imx577_ep1>; >>>>>> +            }; >>>>>> +        }; >>>>>> +    }; >>>>>> +}; >>>>>> + >>>>>> +&cci { >>>>>> +    status = "okay"; >>>>>> +}; >>>>>> + >>>>>> +&cci_i2c1 { >>>>>> +    #address-cells = <1>; >>>>>> +    #size-cells = <0>; >>>>>> + >>>>>> +    camera@1a { >>>>>> +        compatible = "sony,imx577"; >>>>>> +        reg = <0x1a>; >>>>>> + >>>>>> +        reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>; >>>>>> +        pinctrl-0 = <&cam2_default>; >>>>>> +        pinctrl-names = "default"; >>>>>> + >>>>>> +        clocks = <&camcc CAM_CC_MCLK2_CLK>; >>>>>> +        assigned-clocks = <&camcc CAM_CC_MCLK2_CLK>; >>>>>> +        assigned-clock-rates = <24000000>; >>>>>> + >>>>>> +        avdd-supply = <&vreg_s4a>; >>>>> >>>>> Just one voltage supply? >>>> yes, 22pin camera module only have one pin for power.> >>> >>> It's common that mezzanine boards are supplied with power from S4A or >>> VBAT, >>> I've never seen a camera module supplied with just one voltage >>> regulator, >>> that's why it attracts attention. >>> >>> What is a camera module here, is it on an attachable vision mezzanine >>> like >>> on RBx series or a part of Talos EVK PCB like on QRD series? >>> >>> If it is a mezzanine, the support of mezzanine boards should be done as >>> a DT overlay. >>> >> >> It`s like RBx series, does not include a camera sensor >> by default. >> > > Then to add the image sensor support please follow the model with DT > overlays, > and it means you shall get a schematics of the mezzanine to describe the > attachable board. > > When you get the schematics, you will get a valid view on voltage > distribution, > sensor supplies will be derivatives from VBAT or S4A anyway, I believe. > > See sm8550-hdk-rear-camera-card.dtso or qrb5165-rb5-vision- > mezzanine.dtso as > the references. > yes, I think the module will distribute the supplies of S4A. Thanks, Wenmeng