From: Damien Le Moal <dlemoal@kernel.org>
To: Zizhi Wo <wozizhi@huaweicloud.com>,
axboe@kernel.dk, nilay@linux.ibm.com,
linux-block@vger.kernel.org, kch@nvidia.com,
johannes.thumshirn@wdc.com, kbusch@kernel.org,
bvanassche@acm.org
Cc: linux-kernel@vger.kernel.org, yangerkun@huawei.com,
chengzhihao1@huawei.com, wozizhi@huawei.com
Subject: Re: [PATCH V2 6/6] null_blk: free global tag_set on init error path
Date: Tue, 7 Jul 2026 13:24:55 +0900 [thread overview]
Message-ID: <45b8c838-4d32-48d0-bb07-b2833ee4d15a@kernel.org> (raw)
In-Reply-To: <20260707025542.1299859-7-wozizhi@huaweicloud.com>
On 7/7/26 11:55, Zizhi Wo wrote:
> From: Zizhi Wo <wozizhi@huawei.com>
>
> If shared_tags is enabled, null_setup_tagset() allocates the global tag_set
> via null_init_global_tag_set(). If device creation later fails, err_dev
> destroys the default devices and calls unregister_blkdev(), but never frees
> the global tag_set. Since module init failed, null_exit() is never invoked,
> so the global tag_set's tags and maps are permanently leaked.
>
> Free the global tag_set in err_dev, matching null_exit() which does
> if (tag_set.ops) blk_mq_free_tag_set(&tag_set).
>
> Fixes: 82f402fefa50 ("null_blk: add support for shared tags")
> Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
Looks OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-07-07 4:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 2:55 [PATCH V2 0/6] null_blk: fix init/exit races, leaks and cleanup Zizhi Wo
2026-07-07 2:55 ` [PATCH V2 1/6] null_blk: use DEFINE_MUTEX for the file-scope mutex Zizhi Wo
2026-07-07 4:07 ` Damien Le Moal
2026-07-07 2:55 ` [PATCH V2 2/6] null_blk: give the file-scope mutex a descriptive name Zizhi Wo
2026-07-07 4:16 ` Damien Le Moal
2026-07-07 6:24 ` Zizhi Wo
2026-07-07 6:28 ` Damien Le Moal
2026-07-07 6:45 ` Zizhi Wo
2026-07-07 2:55 ` [PATCH V2 3/6] null_blk: register configfs subsystem after creating default devices Zizhi Wo
2026-07-07 4:18 ` Damien Le Moal
2026-07-07 2:55 ` [PATCH V2 4/6] null_blk: move unregister_blkdev() after destroying dev in null_exit() Zizhi Wo
2026-07-07 4:19 ` Damien Le Moal
2026-07-07 2:55 ` [PATCH V2 5/6] null_blk: don't locklessly overwrite dev state after apply_fn Zizhi Wo
2026-07-07 3:38 ` Zizhi Wo
2026-07-07 4:21 ` Damien Le Moal
2026-07-07 7:33 ` Nilay Shroff
2026-07-07 8:24 ` Zizhi Wo
2026-07-07 2:55 ` [PATCH V2 6/6] null_blk: free global tag_set on init error path Zizhi Wo
2026-07-07 4:24 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45b8c838-4d32-48d0-bb07-b2833ee4d15a@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chengzhihao1@huawei.com \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=wozizhi@huawei.com \
--cc=wozizhi@huaweicloud.com \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox