From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011059.outbound.protection.outlook.com [52.101.65.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC833E3DA0; Wed, 6 May 2026 09:25:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.59 ARC-Seal:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778059508; cv=fail; b=hK7Ge8rRLQuXckA49pKkoQYuwXroM7Xfs8WfqEVJXg2wFYsDDMsdY9OQFIkig/3IAcF9gddQnwYAD110Wgo3rc8U/FWk+FxvuOMFAQoDcgxnMLxVDA7yH59fEKrJ5l8gpFjQNXfJX7Rr3AmzbCck8uece/02yU+OS72kIVCrZhU= ARC-Message-Signature:i=3; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778059508; c=relaxed/simple; bh=Q5tNb5OTvbqfZL4f0Nu3VpIS2+Uh2T/bEJjnmm2tK9o=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=eDKEOm5NuBX3TEnIIF1A+DZgajCrPmplKD/iWFbtyPe1L/HC4v7BKoD/4Wr3qpKGX3DCVU4SiBI/05oDhBcELWt13RA6oTat5MqNiQrBlZFqNHWlzIgaZmMgB2KKQSNqVN8fE2giFDuRV3SxMjKG5MfdPFFb+XU5dgjReQ+i23s= ARC-Authentication-Results:i=3; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=U6fKl/9s; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=U6fKl/9s; arc=fail smtp.client-ip=52.101.65.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="U6fKl/9s"; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="U6fKl/9s" ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=s0GUNzWEOhb+FaEm3vhRkHLcjikNrXb5AAF+1ViZbPIlMz2kgVZutyfFpSZukHusfjnh0ko07qPmdfgzQ7/EGTK/ZFbqMrZhRE+sdFEsem4muXFxo6IHO28mEg94w9yM8CrgxwHaPbiTw6RrKhpun5DHHhJO91lW/9TpfZM/eZBn1k0ntekBHm86cKTAT4+N7PEpFA4FFZ0Ik1t93FicuOFoXzxzqwXlZNqwBXvQlzDejZG+gdVdKl8UFc2HQwMIydkaONf3wZDQTt6ESKW+GLzjyoQayC1qc0ZBdyWDyfs51njvvotQWbSJzVzog9oWPy0uDiZobz1GfWsd8Bn6sA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF8xbkF1f29S0Ic+T20p5AQKegZlB38/fmLetIe4O5E=; b=YteiekAnYiDfBsWOUBDJROMLw0SzVM9Z6HE5Pju7OX9FWDOklC+FV2dFChYCzCanGfeRqH8FjQoinVvQVNAKzs+r9yOTinao1J1/+FNeTmTuQswXXxvBsi+XkPlKs9QdqbTFJDH0JkCpa5cnfoqSM/kB/bFtS7mZkZlutJUwRsv7mMXqiAnsDOxh/KpMdr3fZ9TYTuqi2WkIpX2mnLllLhNra9VaemIFV1y3m9K+wKI0dZUN9vFf/ee6aONH2CaCErfP1/rxIetOLW0hYfy55xjlONB/F4ET8BTH9DRnDE3xQVfEgNj5LDJT5IBfG+2vRDQG7lMMXIk56lkNO3CZPA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=kernel.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF8xbkF1f29S0Ic+T20p5AQKegZlB38/fmLetIe4O5E=; b=U6fKl/9s4pi/IocfMLBUEdLv0LZQd2r+CDzrvocxXrZto+iJ5HWteYAo/SaQrP8swyxPf3NUA7633rb46LadcAGVP1va9wiXmx4hmuyo1uBHLObnSFUYbtK497EqNsC1BYDwxfY2HKArrLod8wkKsR5n41rxYXKMj1wEv6bBmPA= Received: from AS4P192CA0047.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:658::19) by PAWPR08MB11488.eurprd08.prod.outlook.com (2603:10a6:102:50a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.15; Wed, 6 May 2026 09:25:02 +0000 Received: from AMS1EPF0000004B.eurprd04.prod.outlook.com (2603:10a6:20b:658:cafe::91) by AS4P192CA0047.outlook.office365.com (2603:10a6:20b:658::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.15 via Frontend Transport; Wed, 6 May 2026 09:25:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS1EPF0000004B.mail.protection.outlook.com (10.167.16.136) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Wed, 6 May 2026 09:25:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VCcIVVqtnP2Q19Ir3SlYQbZIJdSLVD0Z8eBtthZuXpiHWbIGEf9A5zUDwDPGgxJkBFIxmq4mgMEGlIUmOlOAudwv+8+iC8G0prUuHie+IXgRqdBQP+cW8mgwdlhSxyH+vMo3Mg1ru1YsO4/Rl+Q7fYR+xgU0ljm5MlOTNhOwDilRiiuantB7IcOYlOB4Yo+e6/76cyBP/TIwsKgd0mP1d7Aw5W6wTvBUzFrUUny8BuVq6zFQd2kNvTS8xmLt7ANUw7FqYhCkbKMh01xii5wXQ39BRphPPeQzkKaOisZQ+UEsyEQH5rxPI376A/KL5guI06nW+GpHC0mHMmeU14SxHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PF8xbkF1f29S0Ic+T20p5AQKegZlB38/fmLetIe4O5E=; b=YHR2XbREB6Pop5gY21WEQi1zykF2Kw74pCOectiX7MPKGjywxAEAOv86w+dmErk1vvyD/wx740MEizliOW4F/OTUzCyqmbj55zf4tdYpgGbCwqIFWI5Q4SkpyQpOp4xhOH+f/oDnqBu0fgQpnLfQkmIQkEUvYRtu3lup8r9aOAAmm1U3H034Mn1TCLqdgWVC6uEpPOvKx91+EF0XrQXoB48FFviW7OMWceFHAOMzttwHfq9WskUOViyZ/BOLrlIHrmCzLSORANWOiiaNNk9iOxcFIVV2vb+MKzRlLyc3bQUuN2jB8i6IEVIJBM+YIZJaL/l8JGwHASxgq1JbUW0FBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PF8xbkF1f29S0Ic+T20p5AQKegZlB38/fmLetIe4O5E=; b=U6fKl/9s4pi/IocfMLBUEdLv0LZQd2r+CDzrvocxXrZto+iJ5HWteYAo/SaQrP8swyxPf3NUA7633rb46LadcAGVP1va9wiXmx4hmuyo1uBHLObnSFUYbtK497EqNsC1BYDwxfY2HKArrLod8wkKsR5n41rxYXKMj1wEv6bBmPA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) by PAVPR08MB9770.eurprd08.prod.outlook.com (2603:10a6:102:31e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Wed, 6 May 2026 09:23:57 +0000 Received: from DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047]) by DU0PR08MB9203.eurprd08.prod.outlook.com ([fe80::f1e:73f2:57df:4047%2]) with mapi id 15.20.9891.008; Wed, 6 May 2026 09:23:57 +0000 Message-ID: <45f58d3f-ce7e-458f-a986-0de9572c1667@arm.com> Date: Wed, 6 May 2026 14:53:49 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 24/54] selftests/mm: hugepage_settings: use unsigned long in detect_hugetlb_page_size To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Luiz Capitulino , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260428204240.1924129-1-rppt@kernel.org> <20260428204240.1924129-25-rppt@kernel.org> From: Sarthak Sharma Content-Language: en-US In-Reply-To: <20260428204240.1924129-25-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MA0PR01CA0054.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:ac::6) To DU0PR08MB9203.eurprd08.prod.outlook.com (2603:10a6:10:417::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB9203:EE_|PAVPR08MB9770:EE_|AMS1EPF0000004B:EE_|PAWPR08MB11488:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d929fa8-f7f9-49c0-8734-08deab515998 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|18002099003|56012099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: XuWxdEbf2eklGadKIlSPAsHsF4SfCJLwyaSQdsUR4wgw3mVSWqaKexURct/dVfa/UJYxDV+WYrBxkxt10f8fFngOmneSG0eQD7Vtpvh2frVq9n/+G1hdsu0JY5F94A7CBj3nPj03FWI70PsLBnQxENA/N5kF9fkUk9rzsda/2upWcOUTFR/jG4h4sPAsKbodN0W+DP8yom4Dw1W4oQUi5zZU6lCXSWXzInfK+ZapNiornMEvHs6t4badf96QXHZfSXN/J9tyAa20Gx/DqMcf3hi8Gixvsh/9pXc/wxFPPzt3gD+1YyJwAjaMzCsNlahwEmhBgBY5y78mIlOc/+QY4D9ffmTVFP0Z/bHkq0wZOnjt9x2eUvzbg/8lFgSKTb/C4mDHvuLRgYJJqMpKYHteaZTh5bHetehBUJyF49E8w5OdQwYigvQUrIzcB8yvsFgktLBXpw0q+4gAq073tqo3o/UAGEwXsg1hkx7tsB3K/I1ZrF2hNLL8X1fwj4Z4k+/tnlwyssD924pfjDZbOV/STdj2OgUJV5iOiC65JlHBwTshigy8lSU47CqTA1y8YYocuH9WAs0D3OptDc3X3OHKWktNG0BQ1y3gKAOCUk/LavSUmhcC7Sucg0vNB4TEiZHaBLgiaODNgAY3fGNbs88IymSHHPvx2lI/8W5lYbZpTyfA5GqxVUDjolcSBmtLa41B X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR08MB9203.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(18002099003)(56012099003)(22082099003);DIR:OUT;SFP:1101; X-Exchange-RoutingPolicyChecked: dEhfrblY7b5YkcYdH0ZhgA7H57nT13eQ/GQE25KVyV0LKxPNYwmKSL/rslV+Gkn+3/L+8jOnleUuChE1MQYmyzn3XHHmc3w+ogl7Eq0KhbnBk4H30QzyLb25hqqagp7gJZvAVFb2+lR1SmQBzLI4jVXO6Nodp2eiB70vwZ55G5DvLQAmiFVEVajSicmgDskOvjYiORdSG1g+Cps1v1Tqkfz/ZaHhwVWVvGYF+0YuKykD/3bJ5skrcjfxcFVO8vdpUeRaehBiFcCQy/stXZvy4R4XUgmh+uiIZ3xKH8ODQl5UhdfIJ75ZHz7GKns0NTgE66soTDRYFFzsAzA6x1answ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9770 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF0000004B.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d5c3b6e3-21c2-4f03-f8b3-08deab5132f8 X-Microsoft-Antispam: BCL:0;ARA:13230040|14060799003|82310400026|35042699022|1800799024|36860700016|7416014|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: GlBnZIIor02hJVgfyLu2+fNDvaegWN4x5F+wfiE5cP0p3ZGZ7/N9tD+jZTDx0wP1QwYajOZc95uoLxst1UbFErehzHFezXp8hqG55rnA60xcUZjEzZAkZVArwDn+/hSLYMSO8x5ajQ3NTMY5wKmlj8PpE9RSgmRvCXI9NHTakX+M68bMrD2GqxOpCYimeOLj/h2KM4MD1jSc2ix+1d7yd633TrFlfnj56G5o2Dv8vepXjS/ueKDyCnFzXIPV5jrjIveU3vwvZ4WJxjtuibjvHW6ov1nmGRiSSR+ni2iz2BALnm7xAbSnoHmbB+kQ/SWgcyT2b3K0rE/wICyj8iQE/DVyl3wD5FIZ5vHmdV7cDW843GL73jJWhPivzd+DRDdYlr19UryEcqXJm24nyEEhB3ZiPzGTz2IVLLKkLkpheK/q/atmUuUDZrt1OvHm1Tq9LE5w0ZLwgvilTNxgloDDSHWAujgyZpvnQtrI2iyLTIFzRg6PzjjVFz9iEoJfOVy3ea1xy1XZ3V1Er48wS2BeCsF7LtTamjT3EMMGKLR1exR2HTuhqCSEWhTf5R0Rpfz1ZXkC9qL+8BCpQe3vAgVqzLCCYqLaQFQONfQQfVQzuOmsRJuQrUKHKNEp4vmy/jU2lZKURowi/eooCSyU29hB+6TZ5TNyuCRRJNpOwLuq+n+60s3b3AhoB7ygPMw/4Mv/YpUuhb82n3OMs7XtqGZL/1YlAz9tHpbwzQC12RaL+ho= X-Forefront-Antispam-Report: CIP:4.158.2.129;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:outbound-uk1.az.dlp.m.darktrace.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(14060799003)(82310400026)(35042699022)(1800799024)(36860700016)(7416014)(376014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3eS4wofNqjhEtF2EnkFDdo4SJJnRDeNCmw/uFOjoI3GfbksHZcwitnJltyUJSw6tRqJRMskoSxiHz6vA/Vf7sn/gBho8eFgBwGTWerQtXGkd4n5WdN93WmXTpQ6NsrVfFGxPOcygDUcVnsNMDaBseMwxpN82h52D+P7Z05eSB/hBcgsO3ym9OEjcQLlHPidtqrXpJMyYUnfLdYRwaN+qjGUglrvCv4ChDlcM5EZQwMLq7rOv+lt5ZX9ufpzwkcMW8y2ZNQxsUGV95mMwU/pqXVpg8sCV0OZUcnOdv14dgKgmbPsQ7l3E7ZOdqrQ/Wco9TbjYZDfC/Zl4sF0Mdn5sGfvT/oZZ9rQIS1n4mOeOgLn1amsthBcs4O/H0XJ9m5YfBoPVbs8BCDc0cfVActHJQwTsHhFcnKkK9/bKmraioipzDWZ48fUQlhbRDc+sYjP9 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2026 09:25:01.6112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d929fa8-f7f9-49c0-8734-08deab515998 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[4.158.2.129];Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000004B.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB11488 On 4/29/26 2:12 AM, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > ... instead of size_t to avoid type mismatch in 32 and 64 bit builds. > > Signed-off-by: Mike Rapoport (Microsoft) Looks good to me. Reviewed-by: Sarthak Sharma > --- > tools/testing/selftests/mm/hugepage_settings.c | 2 +- > tools/testing/selftests/mm/hugepage_settings.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugepage_settings.c b/tools/testing/selftests/mm/hugepage_settings.c > index ebaa621c45c6..8f563315b1fc 100644 > --- a/tools/testing/selftests/mm/hugepage_settings.c > +++ b/tools/testing/selftests/mm/hugepage_settings.c > @@ -399,7 +399,7 @@ bool thp_is_enabled(void) > return mode == 1 || mode == 3; > } > > -int detect_hugetlb_page_sizes(size_t sizes[], int max) > +int detect_hugetlb_page_sizes(unsigned long sizes[], int max) > { > DIR *dir = opendir("/sys/kernel/mm/hugepages/"); > int count = 0; > diff --git a/tools/testing/selftests/mm/hugepage_settings.h b/tools/testing/selftests/mm/hugepage_settings.h > index 320b97e768e8..9357d07e6c1b 100644 > --- a/tools/testing/selftests/mm/hugepage_settings.h > +++ b/tools/testing/selftests/mm/hugepage_settings.h > @@ -90,7 +90,7 @@ bool thp_is_enabled(void); > > /* HugeTLB */ > > -int detect_hugetlb_page_sizes(size_t sizes[], int max); > +int detect_hugetlb_page_sizes(unsigned long sizes[], int max); > unsigned long default_huge_page_size(void); > unsigned long get_free_hugepages(void); >