The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	Duoming Zhou <duoming@zju.edu.cn>,
	linux-hams@vger.kernel.org, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Jörg Reuter" <jreuter@yaina.de>,
	"Paolo Abeni" <pabeni@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Lars Kellogg-Stedman" <lars@oddbit.com>,
	"Simon Horman" <horms@kernel.org>
Subject: Re: [PATCH net v3 2/2] ax25: Change kfree() in ax25_dev_free() to ax25_dev_put()
Date: Mon, 6 May 2024 17:50:19 +0200	[thread overview]
Message-ID: <45f6991d-1595-4ba1-956b-acfcbbdfe8de@web.de> (raw)
In-Reply-To: <53925353450dea9a705d67ad225b589e8508042c.1715002910.git.duoming@zju.edu.cn>

…
> Replace it with a ax25_dev_put() call instead.
> ---
> Changes in v3:
>   - Make commit messages more clearer.
> +++ b/net/ax25/ax25_dev.c
> @@ -188,16 +188,13 @@ struct net_device *ax25_fwd_dev(struct net_device *dev)
>   */
>  void __exit ax25_dev_free(void)
>  {
> -	ax25_dev = ax25_dev_list;
> -	while (ax25_dev != NULL) {
> -		s        = ax25_dev;
> -		netdev_put(ax25_dev->dev, &ax25_dev->dev_tracker);
> -		ax25_dev = ax25_dev->next;
> -		kfree(s);
> +	list_for_each_entry_safe(s, n, &ax25_dev_list, list) {
> +		netdev_put(s->dev, &s->dev_tracker);
> +		list_del(&s->list);
> +		ax25_dev_put(s);
>  	}
> -	ax25_dev_list = NULL;
…

Can the increased application of the Linux list API be offered as
a separate update step?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc7#n81

Regards,
Markus

      reply	other threads:[~2024-05-06 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 14:08 [PATCH net v3 0/2] ax25: Fix issues of ax25_dev and net_device Duoming Zhou
2024-05-06 14:08 ` [PATCH net v3 1/2] ax25: Fix reference count leak " Duoming Zhou
2024-05-06 14:46   ` Dan Carpenter
2024-05-06 15:11   ` Markus Elfring
2024-05-06 14:08 ` [PATCH net v3 2/2] ax25: Change kfree() in ax25_dev_free() to ax25_dev_put() Duoming Zhou
2024-05-06 15:50   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45f6991d-1595-4ba1-956b-acfcbbdfe8de@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=duoming@zju.edu.cn \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jreuter@yaina.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=lars@oddbit.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox