From: "chenjun (AM)" <chenjun102@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "xuqiang (M)" <xuqiang36@huawei.com>
Subject: Re: [PATCH] irqchip/mbigen: Fix incorrect null pointer check
Date: Sun, 18 Feb 2024 03:13:05 +0000 [thread overview]
Message-ID: <45fe193a87fc4a5cb2e3233386b47dc7@huawei.com> (raw)
In-Reply-To: 874jecisku.ffs@tglx
在 2024/2/13 18:09, Thomas Gleixner 写道:
> On Mon, Jan 29 2024 at 21:00, Chen Jun wrote:
>
> That's not about an incorrect NULL pointer check. That's about using a
> function which is guaranteed to return NULL on your platform, no?
>
>> bus_get_dev_root(&platform_bus_type) always returns NULL.
>
> Lacks an explanation why this always returns NULL.
>
Thank you for the reply.
bus_get_dev_root returns sp->dev_root set in subsys_register.
And subsys_register is not called by platform_bus_init.
So, for platform_bus_type, bus_get_dev_root always returns NULL.
> Thanks
>
> tglx
>
>
next prev parent reply other threads:[~2024-02-18 3:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 13:00 [PATCH] irqchip/mbigen: Fix incorrect null pointer check Chen Jun
2024-02-13 10:09 ` Thomas Gleixner
2024-02-18 3:13 ` chenjun (AM) [this message]
2024-02-18 19:58 ` Thomas Gleixner
2024-02-13 10:11 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45fe193a87fc4a5cb2e3233386b47dc7@huawei.com \
--to=chenjun102@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox