From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754871AbcIANw1 (ORCPT ); Thu, 1 Sep 2016 09:52:27 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56087 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbcIANwZ (ORCPT ); Thu, 1 Sep 2016 09:52:25 -0400 From: Arnd Bergmann To: kbuild test robot Cc: Baoyou Xie , kbuild-all@01.org, gregkh@linuxfoundation.org, robh@kernel.org, p.zabel@pengutronix.de, peter.chen@freescale.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] USB: core: add missing header dependencies Date: Thu, 01 Sep 2016 15:45:05 +0200 Message-ID: <4603160.93MHTzZajR@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <201609012133.XOcIc0Eq%fengguang.wu@intel.com> References: <201609012133.XOcIc0Eq%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:0iSu7JPTgM6F7SWwj5QMp95TdRLMUCf5wG5gDlsCjksrY5G6Ykj wj+1Nblo9LIDXaMU5/v2sivVBvtrKrOgBks6dMOlvOttcCyZKDKGscPceCtMpXoq4oTTb+w sk3/tMmkRvQHPiKhVqjirp615T9hnMvzKXXb9FvuyHZSbsqexrAo3oy2YK/UGGbQf0NoGou XQnmI/NrSM8Fo8XXNO9Mg== X-UI-Out-Filterresults: notjunk:1;V01:K0:R4syT2oohhw=:AvRnnlTbgQ42c+2i2gpHYn HcX2S18fRTWkCAwafoio7i8bx+XzztxSPUE/bHR6Oz71XVM0jeU2HH2aU3go6uwyNzFxJPgMf AXLLLjEikiIaZO7Sk3g0l3DQHMokz0gLuIDF3zuujb5Vys21+RiU8YTxJDtfQ+oPoJ1ozZKlv en7sS9/9ON9XeL9ZxUp/RN2uZaSzyyIwhOK9cXlyjqKyr36rOA8DEvAjwfl+Ph0sqEa6smO0w amzD7SEc6G0gyWJndSykK9gQ+WVo8NP/Vb7Vbk2yoY11P/r/V/IFVbLeMBSRl2ega/Xz6R7j3 XFRSh2S5tHElGNzW5I3pEJNTPQQu4/ES4BcOKXKve4k7M8j56jQAQW3Dj7VrtdXmeRoDN0CIO 480YRlcgKFdM9265tDcXlTISQ33XdIH7V90PXtzl5tYoHgQsEpHx97nGqFGfyKHWeFtnRgFoQ jdO7Pr/dz+i65rjFikSH9hXmQeY2KKGk7TFP26MRuz72erVlcRG6evelY7pffmxXqok54BsAl tN3AvSxZO3Qa4VJXF2mL7ndzGwdnGXO9GkCC6BV2RC57rcwsHmCxjvEpvMdbU1fwBVh/O/yAY KxzJwsS2pmny4m8MVmaSZ/ckaY4hPOiS75LBeLZaIXdxmXeuBNyetOzv24wSVGiwFpn54Po1c pJS108tYbp//b0CGIrDswDdmX/qsl+sFTriBWBedC+lXWz952mgZQ9McTnvurrw5DtUpr0Ft0 fkOxNWmDDoNxk2j4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 1, 2016 9:33:59 PM CEST kbuild test robot wrote: > Hi Baoyou, > > [auto build test ERROR on arm-soc/for-next] > [also build test ERROR on v4.8-rc4] > [cannot apply to usb/usb-testing next-20160825] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on] > [Check https://git-scm.com/docs/git-format-patch for more information] > We already have a correct version of this patch in linux-next, see below. Arnd commit 0573f2c519e570d056989e57565e1ff1640dd794 Author: Peter Chen Date: Wed Jun 15 11:25:43 2016 +0800 usb: core: of.c: fix defined but not declare warning The helper usb_of_get_child_node is defined at of.c, but missing its declare as a global function. Fix it by adding related header file as well as compile it on conditional of CONFIG_OF. Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Alan Stern Cc: linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk Signed-off-by: Peter Chen Reported-by: Ben Dooks Signed-off-by: Greg Kroah-Hartman diff --git a/drivers/usb/core/Makefile b/drivers/usb/core/Makefile index 9780877010b4..da36b784a0ef 100644 --- a/drivers/usb/core/Makefile +++ b/drivers/usb/core/Makefile @@ -5,8 +5,9 @@ usbcore-y := usb.o hub.o hcd.o urb.o message.o driver.o usbcore-y += config.o file.o buffer.o sysfs.o endpoint.o usbcore-y += devio.o notify.o generic.o quirks.o devices.o -usbcore-y += port.o of.o +usbcore-y += port.o +usbcore-$(CONFIG_OF) += of.o usbcore-$(CONFIG_PCI) += hcd-pci.o usbcore-$(CONFIG_ACPI) += usb-acpi.o diff --git a/drivers/usb/core/of.c b/drivers/usb/core/of.c index 2289700c31d6..3de4f8873984 100644 --- a/drivers/usb/core/of.c +++ b/drivers/usb/core/of.c @@ -18,6 +18,7 @@ */ #include +#include /** * usb_of_get_child_node - Find the device node match port number