From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761894AbcLSNMA (ORCPT ); Mon, 19 Dec 2016 08:12:00 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:52326 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760887AbcLSNL5 (ORCPT ); Mon, 19 Dec 2016 08:11:57 -0500 X-AuditID: cbfee61b-f79d86d00000197e-13-5857dc87801a From: Bartlomiej Zolnierkiewicz To: Kees Cook Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: use designated initializers Date: Mon, 19 Dec 2016 14:11:33 +0100 Message-id: <4605973.6cdfMDcWfH@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20161217010203.GA140420@beast> References: <20161217010203.GA140420@beast> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t9jQd32O+ERBlu+ilqc6c61ONH3gdXi 8q45bA7MHrMbLrJ4fN4kF8AU5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesb EqSkUJaYUwrkGRmgAQfnAPdgJX27BLeMGWeXMxbc56p40viPsYHxD0cXIyeHhICJxKkzh9gh bDGJC/fWs3UxcnEICcxilFiwcTUzhPOVUWJe3zQWkCo2ASuJie2rGEFsEQFVie+XmplBbGYB W4l/73eCxYUFAiRaeh6C1bMA1WxavJ8JxOYV0JRoWrcVrF5UwEtiy752sDingI7EpKc3wXqF BLQlttzaAVUvKPFj8j0WiPnyEvv2T2WFsLUk1u88zjSBEehMhLJZSMpmISlbwMi8ilEitSC5 oDgpPdcoL7Vcrzgxt7g0L10vOT93EyM4Op5J72A8vMv9EKMAB6MSD++B0+ERQqyJZcWVuYcY JTiYlUR4f98ECvGmJFZWpRblxxeV5qQWH2I0BXpwIrOUaHI+MHLzSuINTcxNzI0NLMwtLU2M lMR5G2c/CxcSSE8sSc1OTS1ILYLpY+LglGpgdPOXyEh99MY1hncZe+W9C8vjnq48WnTzoLOg HEt44rtklcpJ9Wu11OT/JieXcFyoUt/hoC3dYrk4wPyE0fGQyfn7fvxacO7PQqGtJSpM0qV2 55tkPMre9yrV/7ro4+Hot2nug4VL7S5cbF7NzDLpoF6Zf5fdh2kcbu23DEweVYcGPHoqOT9a iaU4I9FQi7moOBEA71tWL6QCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, December 16, 2016 05:02:03 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook I have same request as Ingo for x86/floppy patch: please align the two columns vertically while at it. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index 82c0a8caa9b8..42499a1afa07 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -439,9 +439,9 @@ static unsigned long lcdc_sys_read_data(void *handle) > } > > static struct sh_mobile_lcdc_sys_bus_ops sh_mobile_lcdc_sys_bus_ops = { > - lcdc_sys_write_index, > - lcdc_sys_write_data, > - lcdc_sys_read_data, > + .write_index = lcdc_sys_write_index, > + .write_data = lcdc_sys_write_data, > + .read_data = lcdc_sys_read_data, > }; > > static int sh_mobile_lcdc_sginit(struct fb_info *info,