From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753277AbXCZRS5 (ORCPT ); Mon, 26 Mar 2007 13:18:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753265AbXCZRS5 (ORCPT ); Mon, 26 Mar 2007 13:18:57 -0400 Received: from h155.mvista.com ([63.81.120.155]:47647 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753277AbXCZRS4 (ORCPT ); Mon, 26 Mar 2007 13:18:56 -0400 Message-ID: <460800A8.4050501@ru.mvista.com> Date: Mon, 26 Mar 2007 21:19:36 +0400 From: Sergei Shtylyov Organization: MontaVista Software Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803 X-Accept-Language: ru, en-us, en-gb MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void References: <20070119003058.14846.43637.sendpatchset@localhost.localdomain> <20070119003220.14846.14258.sendpatchset@localhost.localdomain> In-Reply-To: <20070119003220.14846.14258.sendpatchset@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > [PATCH] ide: make ide_hwif_t.ide_dma_host_on void > * since ide_hwif_t.ide_dma_host_on is called either when drive->using_dma == 1 > or when return value is discarded make it void, also drop "ide_" prefix > * make __ide_dma_host_on() void and drop "__" prefix BTW, it would also make sense to make hwif->ide_dma_timeout() and hwif->ide_dma_lostirq void too (and possibly drop the ide_ prefix). Their results are *explicitly* ignored. MBR, Sergei