From: Zachary Amsden <zach@vmware.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [patch -mm] i386: use pte_update_defer in ptep_test_and_clear_{dirty,young}
Date: Mon, 26 Mar 2007 12:24:06 -0800 [thread overview]
Message-ID: <46082BE6.30402@vmware.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0703252335560.4535@chino.kir.corp.google.com>
David Rientjes wrote:
> Date: Sun, 25 Mar 2007 23:07:43 -0800
> From: Zachary Amsden <zach@vmware.com>
>
> If you actually clear the bit, you need to:
>
> + pte_update_defer(vma->vm_mm, addr, ptep);
>
> The reason is, when updating PTEs, the hypervisor must be notified. Using
> atomic operations to do this is fine for all hypervisors I am aware of.
> However, for hypervisors which shadow page tables, if these PTE
> modifications are not trapped, you need a post-modification call to fulfill
> the update of the shadow page table.
>
> Cc: Zachary Amsden <zach@vmware.com>
> Cc: Hugh Dickins <hugh@veritas.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
>
Acked-by: Zachary Amsden <zach@vmware.com>
David, thanks for cleaning this up.
next prev parent reply other threads:[~2007-03-26 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-26 6:37 [patch -mm] i386: use pte_update_defer in ptep_test_and_clear_{dirty,young} David Rientjes
2007-03-26 9:08 ` Andrew Morton
2007-03-26 20:24 ` Zachary Amsden [this message]
2007-04-13 17:54 ` Hugh Dickins
2007-04-13 19:05 ` Zachary Amsden
2007-04-13 19:27 ` Zachary Amsden
2007-04-13 20:24 ` Hugh Dickins
2007-04-13 20:59 ` Zachary Amsden
2007-04-16 17:59 ` Hugh Dickins
2007-04-16 18:51 ` David Rientjes
2007-04-16 19:04 ` Hugh Dickins
2007-04-16 19:20 ` David Rientjes
2007-04-16 22:08 ` Zachary Amsden
2007-04-16 22:00 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46082BE6.30402@vmware.com \
--to=zach@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox