public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Stuart MacDonald <stuartm@connecttech.com>,
	"'Oliver Neukum'" <oliver@neukum.org>,
	linux-kernel@vger.kernel.org
Subject: Re: question on tty open and close
Date: Wed, 28 Mar 2007 09:26:57 -0600	[thread overview]
Message-ID: <460A8941.4090405@microgate.com> (raw)
In-Reply-To: <20070328154439.40ca5c3c@the-village.bc.nu>

Alan Cox wrote:
> I'm also not aware of any reason other than history, which means if
> someone cares to double check the other drivers there really shouldn't be
> an obstacle to "fixing" this behaviour.
> 
> Unless anyone knows different ?

As long as the new behavior continues to call
driver->close() if driver->open() succeeds
then I see no problem.

If individual drivers are correctly doing internal
reference counting to handle driver->close() calls
without a preceding successful driver->open() call
(usually just doing nothing), then they should
continue to operate correctly without the extra
and unnecessary driver->close().

-- 
Paul Fulghum
Microgate Systems, Ltd.

  reply	other threads:[~2007-03-28 14:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-28 11:38 question on tty open and close Oliver Neukum
2007-03-28 13:10 ` Stuart MacDonald
2007-03-28 13:16   ` Oliver Neukum
2007-03-28 13:22     ` Stuart MacDonald
2007-03-28 14:44       ` Alan Cox
2007-03-28 15:26         ` Paul Fulghum [this message]
2007-03-28 15:31           ` Alan Cox
2007-03-28 14:54             ` Marcel Holtmann
2007-03-28 15:32             ` Paul Fulghum
  -- strict thread matches above, loose matches on Subject: below --
2007-03-28 14:37 Kilau, Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460A8941.4090405@microgate.com \
    --to=paulkf@microgate.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=stuartm@connecttech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox