Re: [patch] cache pipe buf page address for non-highmem arch

Zach Brown
2007-03-27T22:57:56Z

> +#define pipe_kmap_atomic(page, type) pipe_kmap(page)
> +#define pipe_kunmap(page) do { } while (0)
> +#define pipe_kunmap_atomic(page, type) do { } while (0)

Please don't drop arguments in stubs. It can let completely broken
code compile, like:

pipe_kunmap(SOME_COMPLETE_NONSENSE);

Static inlines with empty bodies are the gold standard.

- z