public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Milind Arun Choudhary <milindchoudhary@gmail.com>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [KJ][PATCH] BIT macro cleanup
Date: Thu, 29 Mar 2007 05:48:14 +0200	[thread overview]
Message-ID: <460B36FE.5050301@student.ltu.se> (raw)
In-Reply-To: <20070328033309.GA9597@arun.site>

Milind Arun Choudhary wrote:
> BIT macro cleanup,now in bitops.h
>
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
>
> ---
>   
<snip>
> diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
> index 0de0c65..5aa3be5 100644
> --- a/drivers/net/s2io.h
> +++ b/drivers/net/s2io.h
> @@ -14,6 +14,7 @@
>  #define _S2IO_H
>  
>  #define TBD 0
> +#undef BIT
>  #define BIT(loc)		(0x8000000000000000ULL >> (loc))
>  #define vBIT(val, loc, sz)	(((u64)val) << (64-loc-sz))
>  #define INV(d)  ((d&0xff)<<24) | (((d>>8)&0xff)<<16) | (((d>>16)&0xff)<<8)| ((d>>24)&0xff)
>   
Why not use "LLBIT(63 - loc)" instead?

Richard Knutsson


      parent reply	other threads:[~2007-03-29  3:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-28  3:33 [KJ][PATCH] BIT macro cleanup Milind Arun Choudhary
2007-03-28 19:09 ` Alexey Dobriyan
2007-03-29  3:28   ` Richard Knutsson
2007-03-30 12:31     ` Milind Arun Choudhary
2007-03-29  3:48 ` Richard Knutsson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460B36FE.5050301@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=akpm@linux-foundation.org \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=milindchoudhary@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox