From: "Darrick J. Wong" <djwong@us.ibm.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Dependent CPU core speed reporting not updated with CPUFREQ_SHARED_TYPE_HW?
Date: Thu, 29 Mar 2007 17:43:16 -0700 [thread overview]
Message-ID: <460C5D24.608@us.ibm.com> (raw)
Hi Venki,
I have a dual-Woodcrest machine here with _PSD tables that specify that
cpufreq coordination between cores is done in hardware with
DOMAIN_COORD_TYPE_HW_ALL. On this particular machine, CPU 0 and CPU 2
are on the same package, and it looks like they have to be at the same
frequency.
However, it seems that acpi_cpufreq_cpu_init() only sets policy->cpus to
the shared cpu mask if software coordination is required. While this
does have the effect of letting the hardware do its coordination job as
advertised, it also means that a frequency change to CPU0 doesn't get
echoed to CPU2 as it should be, and affected_cpus is inaccurate.
This seems like a bug to me. I can whip up a patch to set the policy
cpu mask in all cases and neuter all but one of the MSR/PCT writes if HW
coordination is desired so that HW coordination is preserved and sysfs
is accurate, but I'm curious to know if I've gotten it right.
--D
next reply other threads:[~2007-03-30 0:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 0:43 Darrick J. Wong [this message]
2007-03-30 1:06 ` Dependent CPU core speed reporting not updated with CPUFREQ_SHARED_TYPE_HW? Pallipadi, Venkatesh
2007-06-01 18:43 ` Darrick J. Wong
2007-06-01 21:37 ` Andi Kleen
2007-06-01 22:39 ` Darrick J. Wong
2007-06-02 1:59 ` Pallipadi, Venkatesh
2007-06-02 6:43 ` Dave Jones
2007-06-02 14:19 ` Dependent CPU core speed reporting not updated withCPUFREQ_SHARED_TYPE_HW? Pallipadi, Venkatesh
2007-06-04 17:07 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460C5D24.608@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox