From: Jiri Slaby <jirislaby@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Pedram M <pmessri@gmail.com>,
kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: my first janitorial
Date: Sun, 01 Apr 2007 20:28:55 +0200 [thread overview]
Message-ID: <460FF9E7.1080107@gmail.com> (raw)
In-Reply-To: <20070401170043.27a581cb@the-village.bc.nu>
Alan Cox napsal(a):
> On Sat, 31 Mar 2007 22:24:12 -0700
> "Pedram M" <pmessri@gmail.com> wrote:
>
>> How about this one? Am I doing it right now?
>> If not, please try to explain more to me what I am
>> doing wrong.
>
> You need to hold a reference to the PCI device for the entire duration it
> is used. I think you actually also need something like this to get the whole
> thing using pci references and pci_get_* properly
>
> Alan
>
> --- drivers/char/cyclades.c~ 2007-04-01 15:52:16.000000000 +0100
> +++ drivers/char/cyclades.c 2007-04-01 15:52:16.000000000 +0100
> @@ -4803,7 +4782,7 @@
> cy_card[j].bus_index = 1;
> cy_card[j].first_line = cy_next_channel;
> cy_card[j].num_chips = cy_pci_nchan/4;
> - cy_card[j].pdev = pdev;
> + cy_card[j].pdev = pci_dev_get(pdev);
No, please let this code be, I have a bunch of patches to have pci_probing
for this driver, the remaining part for first set of patches is testing.
thanks,
--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
Hnus <hnus@fi.muni.cz> is an alias for /dev/null
prev parent reply other threads:[~2007-04-01 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9c9aa5d00703310639q68fa5d19k4d8e3bfb56b1fa6@mail.gmail.com>
2007-04-01 5:24 ` my first janitorial Pedram M
2007-04-01 6:16 ` [KJ] " Jaco Kroon
2007-04-01 6:17 ` Willy Tarreau
2007-04-01 19:04 ` Jan Engelhardt
2007-04-01 16:00 ` Alan Cox
2007-04-01 18:28 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460FF9E7.1080107@gmail.com \
--to=jirislaby@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmessri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox