From: James Bruce <bruce@andrew.cmu.edu>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/16] vt-pure-colors.diff
Date: Sun, 01 Apr 2007 14:39:24 -0400 [thread overview]
Message-ID: <460FFC5C.8090200@andrew.cmu.edu> (raw)
In-Reply-To: <Pine.LNX.4.61.0704012002330.12316@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
> Have the Linux kernel set a new VGA palette for the first 16 colors.
> The new values reduce the saturation (white component) and therefore
> increase contrast.
<snip>
While the patch seems fine, this comment is not correct. The patch is
decreasing the *brightness* in order to *increase* saturation.
Saturation[1] is the deepness of a color, not the white component
(brightness, lightness).
- Jim Bruce
[1] http://www.poynton.com/notes/colour_and_gamma/ColorFAQ.html#RTFToC6
next prev parent reply other threads:[~2007-04-01 19:00 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-01 18:13 [PATCH 0/16] Assorted patches Jan Engelhardt
2007-04-01 18:13 ` [PATCH 1/16] vt-sysfs-for-colors.diff Jan Engelhardt
2007-04-02 6:49 ` Antonino A. Daplas
2007-04-02 7:31 ` [PATCH 17/16] Do not reset UTF8 on terminal reset Jan Engelhardt
2007-04-02 9:30 ` Antonino A. Daplas
2007-04-02 11:26 ` Paul LeoNerd Evans
2007-04-02 11:44 ` Antonino A. Daplas
2007-04-02 11:54 ` Paul LeoNerd Evans
2007-04-02 12:47 ` Antonino A. Daplas
2007-04-02 13:20 ` Paul LeoNerd Evans
2007-04-02 13:34 ` Jan Engelhardt
2007-04-02 18:50 ` Pavel Machek
2007-04-01 18:14 ` [PATCH 2/16] vt-pure-colors.diff Jan Engelhardt
2007-04-01 18:39 ` James Bruce [this message]
2007-04-02 6:49 ` Antonino A. Daplas
2007-04-02 7:04 ` Jan Engelhardt
2007-04-02 7:50 ` Antonino A. Daplas
2007-04-02 8:01 ` Jan Engelhardt
2007-04-01 18:14 ` [PATCH 3/16] vt-underline-color.diff Jan Engelhardt
2007-04-02 5:37 ` Andrew Morton
2007-04-02 6:57 ` Antonino A. Daplas
2007-04-01 18:14 ` [PATCH 4/16] vt-printk-color.diff Jan Engelhardt
2007-04-01 18:14 ` [PATCH 5/16] fix-kthread-niceness.diff Jan Engelhardt
2007-04-02 5:39 ` Andrew Morton
2007-04-01 18:15 ` [PATCH 06/16] isofs-add-write-bit.diff Jan Engelhardt
2007-04-01 18:15 ` [PATCH 07/16] kconfig-dynamic-frequency.diff Jan Engelhardt
2007-04-01 18:39 ` Kyle Moffett
2007-04-01 18:42 ` Jan Engelhardt
2007-04-01 18:52 ` Kyle Moffett
2007-04-01 19:01 ` Jan Engelhardt
2007-04-01 19:42 ` [PATCH] Kyle Moffett
2007-04-01 19:47 ` [PATCH] Jan Engelhardt
2007-04-01 20:07 ` [PATCH] Kyle Moffett
2007-04-01 19:50 ` [PATCH] Add a CONFIG_I_KNOW_WHAT_THE_HELL_I_AM_DOING variable Kyle Moffett
2007-04-01 23:03 ` [PATCH] Andi Kleen
2007-04-01 20:22 ` [PATCH 07/16] kconfig-dynamic-frequency.diff Robert P. J. Day
2007-04-01 18:15 ` [PATCH 08/16] console-printk-level.diff Jan Engelhardt
2007-04-01 19:07 ` Randy Dunlap
2007-04-01 18:15 ` [PATCH 09/16] zlib-decompression-status.diff Jan Engelhardt
2007-04-02 17:48 ` Jörn Engel
2007-04-02 18:50 ` Jan Engelhardt
2007-04-01 18:15 ` [PATCH 10/16] show-partitions-on-mount-error.diff Jan Engelhardt
2007-04-02 5:47 ` Andrew Morton
2007-04-02 5:48 ` Andrew Morton
2007-04-02 7:01 ` [PATCH 10/16] show partitions on mount error Jan Engelhardt
2007-04-02 18:59 ` [PATCH 10/16] show-partitions-on-mount-error.diff Pavel Machek
2007-04-04 0:42 ` Jan Engelhardt
2007-04-01 18:16 ` [PATCH 11/16] samba-eintr-fix.diff Jan Engelhardt
2007-04-01 19:09 ` Dave Jones
2007-04-01 19:28 ` Jan Engelhardt
2007-04-01 19:42 ` Dave Jones
2007-04-02 5:53 ` Andrew Morton
2007-04-01 18:16 ` [PATCH 12/16] cifs-use-mutex.diff Jan Engelhardt
2007-04-02 5:36 ` Roland Dreier
2007-04-01 18:17 ` [PATCH 13/16] show-pipesize-in-stat.diff Jan Engelhardt
2007-04-02 5:58 ` Andrew Morton
2007-04-02 6:48 ` Jan Engelhardt
2007-04-02 10:41 ` Eric Dumazet
2007-04-04 0:48 ` Jan Engelhardt
2007-04-04 5:03 ` Eric Dumazet
2007-04-17 8:05 ` Jan Engelhardt
2007-04-01 18:17 ` [PATCH 14/16] kconfig-allow-override.diff Jan Engelhardt
2007-04-01 18:44 ` Sam Ravnborg
2007-04-01 19:09 ` Randy Dunlap
2007-04-01 18:18 ` [PATCH 15/16] use-regular-eth-suffix.diff Jan Engelhardt
2007-04-01 18:42 ` Kyle Moffett
2007-04-02 1:40 ` Jouni Malinen
2007-04-01 18:18 ` [PATCH 16/16] warn-on-kthread-name-truncation.diff Jan Engelhardt
2007-04-02 6:00 ` Andrew Morton
2007-04-02 6:51 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460FFC5C.8090200@andrew.cmu.edu \
--to=bruce@andrew.cmu.edu \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox