The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Avi Kivity <avi@argo.co.il>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Zach Brown <zach.brown@oracle.com>,
	Benjamin LaHaise <bcrl@kvack.org>
Subject: Re: [patch 13/13] signal/timer/event fds v9 - KAIO eventfd support example ...
Date: Sun, 01 Apr 2007 21:42:23 +0300	[thread overview]
Message-ID: <460FFD0F.7080107@argo.co.il> (raw)
In-Reply-To: <Pine.LNX.4.64.0704011000470.26331@alien.or.mcafeemobile.com>

Davide Libenzi wrote:
> On Sun, 1 Apr 2007, Avi Kivity wrote:
>
>   
>> What is the motivation for adding aio_resfd to an individual iocb instead of
>> the entire io context?  It seems redundant, as you can already create multiple
>> io contexts to wait on.
>>     
>
> To add it to the context, you need to either change the context create API 
> (I think no-go here), or add a new syscall just to handle that.
> Doing it in the iocb gives finer grained setup, but can be more work for 
> the user that wants to use it for all the iocbs.
>   

I think it's a bit too fine grained, and a new system call 
(io_bindfd()?) would be easier to use.  In addition, you would move the 
eventfd_fget() out of the submission path.

For the users that want fine grained control, they can already call 
io_setup() multiple times and submit iocbs to different completion rings.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  parent reply	other threads:[~2007-04-01 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-31 20:09 [patch 13/13] signal/timer/event fds v9 - KAIO eventfd support example Davide Libenzi
2007-04-01 15:06 ` Avi Kivity
2007-04-01 17:07   ` Davide Libenzi
2007-04-01 17:23     ` Linus Torvalds
2007-04-01 17:31       ` Davide Libenzi
2007-04-01 18:42     ` Avi Kivity [this message]
2007-04-01 18:49       ` Davide Libenzi
2007-04-01 20:11         ` Avi Kivity
2007-04-01 20:20           ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460FFD0F.7080107@argo.co.il \
    --to=avi@argo.co.il \
    --cc=akpm@linux-foundation.org \
    --cc=bcrl@kvack.org \
    --cc=davidel@xmailserver.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suparna@in.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox