linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Simon Richter <Simon.Richter@hogyros.de>,
	intel-xe@lists.freedesktop.org, 	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Mark xe driver as BROKEN if kernel page size is not 4kB
Date: Fri, 01 Aug 2025 11:20:40 +0200	[thread overview]
Message-ID: <460b95285cdf23dc6723972ba69ee726b3b3cfba.camel@linux.intel.com> (raw)
In-Reply-To: <20250727070413.9743-2-Simon.Richter@hogyros.de>

On Sun, 2025-07-27 at 16:04 +0900, Simon Richter wrote:
> This driver, for the time being, assumes that the kernel page size is
> 4kB,
> so it fails on loong64 and aarch64 with 16kB pages, and ppc64el with
> 64kB
> pages.
> 
> Signed-off-by: Simon Richter <Simon.Richter@hogyros.de>
> Cc: stable@vger.kernel.org

This looks reasonable to me. During your testing, did you notice
whether there were compilation errors on !4K as well? If not, what do
you thing on allowing !4K also for COMPILE_TEST?

Thanks,
Thomas


> ---
>  drivers/gpu/drm/xe/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 2bb2bc052120..7c9f1de7b35f 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config DRM_XE
>  	tristate "Intel Xe2 Graphics"
> -	depends on DRM && PCI
> +	depends on DRM && PCI && (PAGE_SIZE_4KB || BROKEN)
>  	depends on KUNIT || !KUNIT
>  	depends on INTEL_VSEC || !INTEL_VSEC
>  	depends on X86_PLATFORM_DEVICES || !(X86 && ACPI)


  reply	other threads:[~2025-08-01  9:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27  7:04 [PATCH v2 0/1] Mark xe driver as BROKEN if kernel page size is not 4kB Simon Richter
2025-07-27  7:04 ` [PATCH v2 1/1] " Simon Richter
2025-08-01  9:20   ` Thomas Hellström [this message]
2025-08-01 10:19     ` [PATCH v3] " Simon Richter
2025-08-01 14:39       ` Thomas Hellström
2025-08-01 14:56         ` Thomas Hellström
2025-08-01 15:13           ` Simon Richter
2025-08-02  2:40           ` [PATCH v4] " Simon Richter
2025-08-04  9:40             ` Thomas Hellström

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460b95285cdf23dc6723972ba69ee726b3b3cfba.camel@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=Simon.Richter@hogyros.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).